New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement for bufferLength #282

Merged
merged 10 commits into from May 31, 2016

Conversation

Projects
None yet
2 participants
@YongLuo007
Contributor

YongLuo007 commented May 27, 2016

No description provided.

YongLuo007 added some commits May 26, 2016

nBuffer added
added a nBuffer argument to allow the splitted tiles have buffer. The
current splitted tiles, therefore, have greater extent than the original
outputs.
I am still working on a function called mergeWithBuffer (maybe a better
name needed if you guys have) to allow merge all the tiles to the same
as the original rasterlayer x.
change nBuffer to bufferLength
to allow 1) two dimensions buffer, i.e., x and y
2) allow relative buffer when bufferLength is between 0 and 1
xminExtent <- sort(unique(xminExtent))
xmaxExtent <- sort(unique(xmaxExtent))
yminExtent <- sort(unique(yminExtent))
ymaxExtent <- sort(unique(ymaxExtent))

This comment has been minimized.

@achubaty

achubaty May 30, 2016

Contributor

can be simplified using:

    xminExtent <- sapply(x, xmin) %>% unique() %>% sort()
    xmaxExtent <- sapply(x, xmax) %>% unique() %>% sort()
    yminExtent <- sapply(x, ymin) %>% unique() %>% sort()
    ymaxExtent <- sapply(x, ymax) %>% unique() %>% sort()

This comment has been minimized.

@YongLuo007

YongLuo007 May 30, 2016

Contributor

Thanks. I will revise those lines and recreate the pull request.

This comment has been minimized.

@achubaty

achubaty May 31, 2016

Contributor

can you also please ensure you're fully up to date before doing a new PR? there are currently conflicts that need to be resolved.

This comment has been minimized.

@achubaty

achubaty May 31, 2016

Contributor

@YongLuo007 actually, nevermind. I'm going through this PR now. Thanks for your efforts toward this!

@achubaty achubaty referenced this pull request May 31, 2016

Closed

mergeRaster improvements #283

2 of 2 tasks complete

@achubaty achubaty merged commit c98e4d3 into PredictiveEcology:development May 31, 2016

achubaty added a commit that referenced this pull request May 31, 2016

clean up PR #282
* add and improve tests for `splitRaster` and `mergeRaster`
* improve documentation
* improve code formatting

TO DO: see #283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment