New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed a error that detected by travis CI #310

Merged
merged 9 commits into from Oct 4, 2016

Conversation

Projects
None yet
2 participants
@YongLuo007
Contributor

YongLuo007 commented Oct 4, 2016

No description provided.

YongLuo007 added some commits Sep 29, 2016

expectsInput and createsOutput functions added
1. added two functions to generate input and output objects
2. modify new module template to compatible to  these two functions
3. a bug for depsEdgeList function was fixed to compatible to these two
functions
the expectsInput and createsOutput funcations were revised
1. the expectsInput and createsOutput funcations were revised
2. example modules were updated to accommodate these functions
3. spades help file was undated accordingly
4. vignettes was updated accordingly
replace NA_character_ with "NA" in fireSpread module to elimilate err…
…or in travis CI

seems like travis CI treats NA_character_ as a logic, therefore causes
the error for moduleMetadata function
@achubaty

requires the NEWS file be updated to reflect these changes (linked to issues #189, #214). otherwise, aside from formatting, this looks good.

#'
#' @examples
#' library(dplyr)
#' inputObjets = bind_rows(

This comment has been minimized.

@achubaty

achubaty Oct 4, 2016

Contributor

note typo: inputObjects is missing a 'c'

#'
#' @examples
#' library(dplyr)
#' outputObjets = bind_rows(

This comment has been minimized.

@achubaty

achubaty Oct 4, 2016

Contributor

note typo: outputObjects missing 'c' as above

@achubaty achubaty merged commit 10826a0 into PredictiveEcology:development Oct 4, 2016

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

achubaty added a commit that referenced this pull request Oct 4, 2016

achubaty added a commit that referenced this pull request Oct 4, 2016

achubaty added a commit that referenced this pull request Oct 4, 2016

@achubaty

This comment has been minimized.

Contributor

achubaty commented Oct 4, 2016

fixed the problem with NAs that was causing breakage. see 55989b9.

made a few other tweaks and fixes too. thanks for this @YongLuo007.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment