Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in googledrive v1.0.0 #119

Closed
jennybc opened this issue Aug 16, 2019 · 2 comments

Comments

@jennybc
Copy link

commented Aug 16, 2019

I will release googledrive v1.0.0 soon.

There are breaking changes to auth that I believe affect this package.

reproducible still passes R CMD check, at least running "as CRAN", so there is no obstacle for googledrive, in terms of reverse dependencies. But I think you will notice the changes in normal usage of the reproducible package.

The googledrive changes are described in NEWS.md:

https://googledrive.tidyverse.org/news/index.html

There will also be a blog post about the googledrive release and the gargle package, in general.

@achubaty

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2019

Thanks for the head's up @jennybc.

achubaty added a commit that referenced this issue Aug 16, 2019
[WIP] working through googledrive API changes (#119)
NOTE: added TODO re: .httr-oauth

currently seeing test failures due to the changes:

> Can't get Google credentials.
> Are you running googledrive in a non-interactive session? Consider:
>   * `drive_deauth()` to prevent the attempt to get credentials.
>   * Call `drive_auth()` directly with all necessary specifics.
> 1: testInit("raster", opts = list(rasterTmpDir = file.path(tempdir(), "raster"), reproducible.overwrite = TRUE, reproducible.inputPaths = NULL), 
>        needGoogle = TRUE) at testthat/test-prepInputs.R:1682
> 2: googledrive::drive_auth() at /home/achubaty/Documents/GitHub/PredictiveEcology/reproducible.Rcheck/tests/testthat/helper-allEqual.R:29
> 3: stop("Can't get Google credentials.\n", "Are you running googledrive in a non-interactive session? Consider:\n", 
>        "  * `drive_deauth()` to prevent the attempt to get credentials.\n", "  * Call `drive_auth()` directly with all necessary specifics.\n", 
>        call. = FALSE)
achubaty added a commit to PredictiveEcology/map that referenced this issue Aug 16, 2019
achubaty added a commit that referenced this issue Aug 20, 2019
@achubaty

This comment has been minimized.

Copy link
Collaborator

commented Aug 21, 2019

fixed and merged.

thank you @jennybc for advanced notice and for maintaining detailed release notes and package vignettes.

@achubaty achubaty closed this Aug 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.