Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepInputs tests failing #93

Closed
achubaty opened this Issue Jan 8, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@achubaty
Copy link
Collaborator

commented Jan 8, 2019

Some prepInputs tests not run on appveyor/travis/CRAN are failing:

4. Failure: prepInputs doesn't work (@test-prepInputs.R#148) 
5. Failure: prepInputs doesn't work (@test-prepInputs.R#264) 

Both fail because of non-matching extents:

> extent(LCC2005)[1:4]
[1] -1473500  -202250  7283000  8563250
> round(extent(StudyAreaCRSLCC2005)[1:4] / 250, 0) * 250
[1] -1473750  -202000  7282750  8563250

achubaty added a commit that referenced this issue Jan 8, 2019

@achubaty

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 1, 2019

this is still failing, but now with different values:

> extent(LCC2005)[1:4]
[1] -1710250  -186750  7231750  8678500
> round(extent(StudyAreaCRSLCC2005)[1:4] / 250, 0) * 250
[1] -1473750  -202000  7282750  8563250

achubaty added a commit that referenced this issue Mar 1, 2019

@eliotmcintire

This comment has been minimized.

Copy link
Contributor

commented Mar 15, 2019

Fixed with cc75c4d

It was a case of intransitivity of operations...
Needed to spTransform the studyArea directly in cropInputs, instead of the much faster/simpler spTransform of the extent of studyArea. These are the same if the studyArea fills the extent (like a Raster does), but it is not correct otherwise.

eliotmcintire added a commit that referenced this issue Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.