Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngb in projectRaster #63

Merged
merged 18 commits into from Nov 5, 2018
Merged

Conversation

@ianmseddy
Copy link
Contributor

@ianmseddy ianmseddy commented Oct 12, 2018

uses assessDataType to decide which format.

@coveralls
Copy link

@coveralls coveralls commented Oct 13, 2018

Coverage Status

Coverage increased (+0.2%) to 78.361% when pulling e12b934 on ianmseddy:development into ca6035d on PredictiveEcology:development.

@ianmseddy
Copy link
Contributor Author

@ianmseddy ianmseddy commented Oct 30, 2018

I forgot to account for the If scenario where rtm is provided and it can process in memory, so I'll have to add the ngb/bilinear method to that as well.

@achubaty
Copy link
Collaborator

@achubaty achubaty commented Oct 30, 2018

ok, i'll hold off merging until you've dealt with it

warn <- capture_warnings(x <- projectRaster(from = x, to = tempRas, ...))

out <- assessDataType(x) #not foolproof method of determining reclass method
if (out == "FLT4S") {

This comment has been minimized.

@achubaty

achubaty Oct 31, 2018
Collaborator

Suggested change
if (out == "FLT4S") {
if (out %in% c("FLT4S", "FLT8S")) {
x <- projectRaster(from = x, crs = targetCRS, ...)
} else {
x <- projectRaster(from = x, crs = targetCRS, method = "ngb", ...)
}

This comment has been minimized.

@achubaty

achubaty Oct 31, 2018
Collaborator

use sampleMethod from above here?

@achubaty achubaty merged commit 07e89af into PredictiveEcology:development Nov 5, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
achubaty added a commit that referenced this pull request Nov 5, 2018
achubaty added a commit that referenced this pull request Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants