Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes bug (error) when not passing url to preProcess or prepInputs call #65

merged 6 commits into from Nov 2, 2018


Copy link

@tati-micheletti tati-micheletti commented Oct 29, 2018

mainly just inverted two lines and added a NULL to guessed file when url is not passed.

Copy link

@achubaty achubaty left a comment

url = NULL is not the same as the url being unreachable (if user is offline). To me it looks like the only change needed is line 477 where basename(url) is called. It just needs to handle the url = NULL case.

Your changes result in a NULL file being guessed at even when url is provided but not reachable.

Copy link
Contributor Author

@tati-micheletti tati-micheletti commented Oct 31, 2018

Hey Alex, I am not sure this would work. Now that I checked it again, the problem is that when url = NULL, grepl("", url) returns logical(0), which in turn, makes the if statement fail. That's why I first test to see if there is an url provided, and if thats TRUE, it tries to guess the file name. I think that the problem is that I thought that url.exists() was to check if the user provided a url... I fixed it now. Will test it right after lunch!

Copy link

@coveralls coveralls commented Oct 31, 2018

Coverage Status

Coverage decreased (-0.004%) to 78.165% when pulling 55d5a19 on tati-micheletti:development into dded345 on PredictiveEcology:development.

@achubaty achubaty merged commit fbb1ae9 into PredictiveEcology:development Nov 2, 2018
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build is in progress
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants