Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unzipping of ".rar" archives #86

Merged

Conversation

@tati-micheletti
Copy link
Contributor

@tati-micheletti tati-micheletti commented Dec 11, 2018

  • this uses a system call of 7z (Windows) or unrar (Linux/Mac), had to make skip_on_xxx() tests
  • updated news
  • added some other tests to increase coverage
@coveralls
Copy link

@coveralls coveralls commented Dec 11, 2018

Coverage Status

Coverage increased (+0.07%) to 79.72% when pulling 05daaf4 on tati-micheletti:development into 3f795b5 on PredictiveEcology:development.

@tati-micheletti
Copy link
Contributor Author

@tati-micheletti tati-micheletti commented Dec 12, 2018

@eliotmcintire Again freaking igraph doesn't let it pass on AppVeyor for version 3.3... All rest is OK.

@achubaty
Copy link
Collaborator

@achubaty achubaty commented Dec 12, 2018

Skipping on CRAN is fine because of the file downloads, but why skip these tests on Travis/appveyor? If tests fail when the required unrar programs aren’t installed then this should be handled gracefully — check for presence of the unrar utility and report back to the user if not installed.

Because unrar utils aren’t standard we need to add this info to Additional requirements on DESCRIPTION.

R/prepInputs.R Outdated Show resolved Hide resolved
R/prepInputs.R Show resolved Hide resolved
R/prepInputs.R Show resolved Hide resolved
R/prepInputs.R Outdated Show resolved Hide resolved
R/prepInputs.R Outdated Show resolved Hide resolved
tests/testthat/test-preProcessWorks.R Outdated Show resolved Hide resolved
@eliotmcintire eliotmcintire merged commit 83fee35 into PredictiveEcology:development Dec 16, 2018
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants