New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unzipping of ".rar" archives #86

Merged
merged 30 commits into from Dec 16, 2018

Conversation

Projects
None yet
4 participants
@tati-micheletti
Copy link
Contributor

tati-micheletti commented Dec 11, 2018

  • this uses a system call of 7z (Windows) or unrar (Linux/Mac), had to make skip_on_xxx() tests
  • updated news
  • added some other tests to increase coverage
@coveralls

This comment has been minimized.

Copy link

coveralls commented Dec 11, 2018

Coverage Status

Coverage increased (+0.07%) to 79.72% when pulling 05daaf4 on tati-micheletti:development into 3f795b5 on PredictiveEcology:development.

@tati-micheletti tati-micheletti force-pushed the tati-micheletti:development branch from 66ad32d to 84e2e05 Dec 12, 2018

@tati-micheletti

This comment has been minimized.

Copy link
Contributor Author

tati-micheletti commented Dec 12, 2018

@eliotmcintire Again freaking igraph doesn't let it pass on AppVeyor for version 3.3... All rest is OK.

@achubaty

This comment has been minimized.

Copy link
Collaborator

achubaty commented Dec 12, 2018

Skipping on CRAN is fine because of the file downloads, but why skip these tests on Travis/appveyor? If tests fail when the required unrar programs aren’t installed then this should be handled gracefully — check for presence of the unrar utility and report back to the user if not installed.

Because unrar utils aren’t standard we need to add this info to Additional requirements on DESCRIPTION.

@tati-micheletti tati-micheletti force-pushed the tati-micheletti:development branch from 1710b27 to 74c1a69 Dec 13, 2018

Show resolved Hide resolved R/prepInputs.R Outdated
Show resolved Hide resolved R/prepInputs.R
Show resolved Hide resolved R/prepInputs.R
Show resolved Hide resolved R/prepInputs.R Outdated
Show resolved Hide resolved R/prepInputs.R Outdated
Show resolved Hide resolved tests/testthat/test-preProcessWorks.R Outdated

@eliotmcintire eliotmcintire merged commit 83fee35 into PredictiveEcology:development Dec 16, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.07%) to 79.72%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment