Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom job templates for KubernetesFlowRunner #5584

Closed
marvin-robot opened this issue Mar 21, 2022 · 0 comments
Closed

Allow custom job templates for KubernetesFlowRunner #5584

marvin-robot opened this issue Mar 21, 2022 · 0 comments

Comments

@marvin-robot
Copy link
Member

Opened from the Prefect Public Slack Community

sylvain015: [Prefect 2.0][Orion]
Running through the documentation and got a couple questions. Those are about production-related patterns so please tell me if it is a bit early for these discussions.
• If I understand what I'm reading correctly, Orion's Storage is quite different from Prefect 1.0's Storage as it does not only store flow code but also results. Does this mean that GitStorage is not coming back and the new recommended process is to deploy from the CI on validated changes ? Also, this is quite specific to my use case but having to connect to a cloud storage resource to run Orion on Kubernetes could be an issue. We are currently running with GitStorage and a Kubernetes-hosted PostgreSQL instance which means we can manage every Prefect component from Kubernetes configuration.
• The current version of the KubernetesFlowRunner seems to use a fixed specification for the created job. Reading the code, I could not find a way to specify a template the way 1.0's KubernetesRun allows us to. Being able to create precisely sized pods to run flows has been really useful for us and I'd love to be able to keep doing it. Is it a planned feature for the future ?
:thank-you: !

anna: Those are all fantastic observations, thanks for looking into that!

We are aware of the difference between read-only storage classes (such as all Git-based storage classes) vs. read-and-write storage classes such as all object storage classes. We are currently working on that so I'd say we should postpone discussing this for now and you can follow 🔔 our https://discourse.prefect.io/tag/release-notes|release-notes to stay updated on that. There will be definitely a way of using GitHub for storage, but hard to say what exactly this will look like for now.

Regarding the Kubernetes job template, let me open an issue for that.

<@ULVA73B9P> open "Orion: allow specifying a custom job template on a KubernetesFlowRunner"

Original thread can be found here.

@zanieb zanieb changed the title Orion: allow specifying a custom job template on a KubernetesFlowRunner Allow custom job templates for KubernetesFlowRunner Apr 1, 2022
@zanieb zanieb added the v2 label Apr 1, 2022
@desertaxle desertaxle closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants