Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment name to flow run list item crumbs #6951

Closed
3 tasks done
zhen0 opened this issue Sep 23, 2022 · 4 comments
Closed
3 tasks done

Add deployment name to flow run list item crumbs #6951

zhen0 opened this issue Sep 23, 2022 · 4 comments
Assignees
Labels
enhancement An improvement of an existing feature good first issue This issue is good for newcomers ui Related to the Prefect web interface

Comments

@zhen0
Copy link
Member

zhen0 commented Sep 23, 2022

First check

  • I added a descriptive title to this issue.
  • I used the GitHub search to find a similar request and didn't find it.
  • I searched the Prefect documentation for this feature.

Prefect Version

2.x

Describe the current behavior

The flow run list item shows related flow but not deployment info

Describe the proposed behavior

If a flow run is associated with a deployment, add deployment name and a link to the deployment as the first crumb in the list item

Example Use

Users can see at a glance which deployment their run is associated with

Additional context

No response

@zhen0 zhen0 added enhancement An improvement of an existing feature status:triage good first issue This issue is good for newcomers ui Related to the Prefect web interface Quick win Work that should be quick but has significant impact and removed status:triage labels Sep 23, 2022
@pleek91
Copy link
Contributor

pleek91 commented Sep 23, 2022

Would it be appropriate to use the deployment icon text component rather than adding this to the crumbs? We're already doing this on the flow run page.

image

I'm thinking of two things

  • Crumbs will be pretty long with the deployment
  • Not every flow run has a deployment. So we'll end up with crumbs of different sizes making it harder to scan the list.

@kevin868
Copy link
Contributor

Fair points! How about instead of first crumb, put it as the last (right-most) crumb?

I mentioned this request on Slack, because we want easier attribution from the Flow Runs listing. Our work is highly parametrized (using dbt_flow), with the parameters basically reflected in our Deployment name. (ex. the selected DBT node and target)

The search and dropdown filters by 'Deployment' are helpful BUT, I'm still lacking attribution on what exactly is scheduled / failed using the Flow Runs listing. We only have the randomized flow run names, and the other crumbs don't shed enough light on what's run besides 'dbt_flow'. Apologies if the problem was already obvious to you; @zhen0's succinct description is pretty good, but I'm hoping to add some flavor as a new user to Prefect 2.

There is a fair amount of horizontal space, left.. but I understand the hesitation to add more things, as things can begin to look cluttered.

Not every flow run has a deployment. So we'll end up with crumbs of different sizes making it harder to scan the list.

If deployment is the right-most element, I still believe a user looking for a specific deployment (or no deployment) can easily spot their desired flow run. Cheers, thanks for the quick triage, and tagging as 'good first issue' 😄

image

@pleek91
Copy link
Contributor

pleek91 commented Oct 24, 2022

@brandonreid @zhen0 is this done? Deployment and work queue were added to the flow run list item in PrefectHQ/prefect-ui-library#693

@zhen0
Copy link
Member Author

zhen0 commented Oct 25, 2022

Yep! I think we can consider this closed. Thanks @pleek91

@zhen0 zhen0 closed this as completed Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An improvement of an existing feature good first issue This issue is good for newcomers ui Related to the Prefect web interface
Projects
No open projects
Development

No branches or pull requests

4 participants