-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Verbose Agent Logging Option #1532
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some requests for variations on a few logs - this is going to be great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 excellent 🚀
@@ -45,9 +45,8 @@ def __init__(self) -> None: | |||
self._verify_token(token) | |||
|
|||
logger = logging.getLogger("agent") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it matters but this is not a Prefect logger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's intentional - these logs are intended to be streamed to stdout in whatever platform the agent is running in. We should introduce the notion of "Agent logs" to store in Cloud, and find a way of exposing them in a way that is flow-independent but that's a future feature.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
Closes #1501
Adds new agent log level config option
prefect agent start --verbose/-v
to enable orconfig.cloud.agent.level
Why is this PR important?
Allows for finer grained logging from the agent