Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmosdb tasks #1617

Merged
merged 7 commits into from
Oct 16, 2019
Merged

Cosmosdb tasks #1617

merged 7 commits into from
Oct 16, 2019

Conversation

frsann
Copy link

@frsann frsann commented Oct 15, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Add Azure Cosmos DB tasks.

Why is this PR important?

Helps Azure Cosmos DB users create and query data as part of their Flows.

@codecov
Copy link

codecov bot commented Oct 15, 2019 •
edited
Loading

Codecov Report

Merging #1617 into master will increase coverage by 0.05%.
The diff coverage is 100%.

joshmeek
joshmeek reviewed Oct 15, 2019
View reviewed changes
Copy link

@joshmeek joshmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really great! Nice tests! One minor nit

src/prefect/tasks/azure/cosmosdb.py Outdated Show resolved Hide resolved
joshmeek
joshmeek previously approved these changes Oct 15, 2019
View reviewed changes
Copy link

@joshmeek joshmeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will wait for @cicdw's approval as well

cicdw
cicdw reviewed Oct 15, 2019
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question, otherwise this is awesome - we really appreciate all the Azure hooks you're providing, this is excellent!

src/prefect/tasks/azure/cosmosdb.py Outdated Show resolved Hide resolved
src/prefect/tasks/azure/cosmosdb.py Outdated Show resolved Hide resolved
cicdw
cicdw approved these changes Oct 16, 2019
View reviewed changes
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! 🚀

@joshmeek joshmeek merged commit 3d32720 into PrefectHQ:master Oct 16, 2019
zanieb pushed a commit that referenced this pull request Apr 13, 2022
Merge pull request #1617 from PrefectHQ/docs-schedules
34334fb 
Docs: improve schedules documentation with examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicdw cicdw cicdw approved these changes

@joshmeek joshmeek joshmeek left review comments

@jlowin jlowin Awaiting requested review from jlowin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frsann @cicdw @joshmeek