New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance nested / ordered constant treatment #1829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cicdw
previously approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome
@cicdw updated changelog for 0.8.0 |
@jlowin sorry for the extremely delayed reviews on this - looks like there's a merge conflict in the changelog |
Updated! |
cicdw
previously approved these changes
Dec 13, 2019
cicdw
approved these changes
Dec 13, 2019
zanieb
pushed a commit
that referenced
this pull request
Jun 7, 2022
* Bumps minimum compatible prefect version * Bumps ORION_API_VERSION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
This PR enhances the treatment of collections of constants, specifically nested collections and ordered collections.
Previously, collections of constants were represented as a
Collection
task with each item added as an upstreamConstant
(orCollection
) dependency. This had two effects: first, it ignored order; second, it created a confusing graph because something like[1, 2, 3]
would unexpectedly be represented by four tasks.This PR examines nested objects to determine if they only contain constants. If they do, then the entire object is wrapped as a single
Constant
, preserving order and simplicity.This PR also simplifies the
convert_constants
flag by removing it. Instead, if the result ofas_task
is aConstant
, we simply add itsvalue
attribute to the flow's constants.Why is this PR important?
As users are supplying more complex arguments to their tasks, they are discovering this undesirable behavior.