New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some interpolation of config in Prefect server dev commands #2299
Conversation
- Convert ui_path when read from environment variable into a Path object. - Use config file's host and port for hasura and apollo when starting services with `dev services`.
@lauralorenz makes total sense for dev work but I think these env vars set the docker-compose environment as well, and I think that Potentially, since we know the docker-compose file with certainty, we should just not all the hostname to be specified and use hardcode the service names instead in |
I have that the and that the changes in this PR are to a different file, which is only used by the |
…ices-config-interpolation # Conflicts: # CHANGELOG.md
Ah, I apologize, I didn't realize it was two different files! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid the reasonable confusion that @jlowin had I think we should rename the server/cli/dev
make_env
function to make_dev_env
to clarify that it is purely for development purposes. (and it's associated calls)
dev services
.Thanks for contributing to Prefect!
Please describe your work and make sure your PR:
CHANGELOG.md
(if appropriate)docs/outline.toml
for API reference docs (if appropriate)Note that your PR will not be reviewed unless all three boxes are checked.
What does this PR change?
Fixes some config interpolation that wasn't happening when running services independently/not with docker.
Why is this PR important?
Needed to dev on Apollo from Prefect Core; Apollo services could not build Apollo schema or healthcheck Apollo when running from dev services without it. Also needed to be able to build the UI from the env variable path instead of the default.