Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ValueError on flow.replace #2924

Merged

Conversation

sp1thas
Copy link

@sp1thas sp1thas commented Jul 7, 2020

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • add a changelog entry in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

Fixes flow.replace method. During the action of flow.replace updates the flow.slugs dictionary and removes the old task.

Why is this PR important?

Fixes bug #2919

@marvin-robot
Copy link
Member

Here I am, brain the size of a planet and they ask me to welcome you to Prefect.

So, welcome to the community @sp1thas! 🎉 🎉

@sp1thas sp1thas changed the title Issue 2919 relpace task slug valuerror Fix ValueError during flow.replace Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #2924 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Copy link

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sp1thas, this looks good to me.

@jcrist jcrist merged commit 0e04896 into PrefectHQ:master Jul 7, 2020
@sp1thas sp1thas changed the title Fix ValueError during flow.replace Fix ValueError on flow.replace Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants