explicit exception chaining for spacy tasks#3479
Merged
jcrist merged 1 commit intoPrefectHQ:masterfrom Oct 12, 2020
sp1thas:explicit-exception-chaining-for-spacy-tasks
Merged
explicit exception chaining for spacy tasks#3479jcrist merged 1 commit intoPrefectHQ:masterfrom sp1thas:explicit-exception-chaining-for-spacy-tasks
jcrist merged 1 commit intoPrefectHQ:masterfrom
sp1thas:explicit-exception-chaining-for-spacy-tasks
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds explicit exception chaining so that exception stack traces are a bit easier to comprehend. See #3306 for a lot more detail and background discussion on this.
Thanks for your time and consideration!
note: Issue body is copied from #3320, created by @jameslamb.
Changes
Uses explicit exception chaining like raise
RuntimeError("whatever") from excin all the places in src/prefect/tasks/spacy/* that are missing it.You can confirm that they were all caught by running the following from the root of the repo:
Importance
This pull request will make some of
prefect's stack traces a bit easier to understand, to improve the user experience in debugging.Checklist
This PR:
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)