Skip to content

specify slack webhook_secret on runtime#3522

Merged
joshmeek merged 4 commits intoPrefectHQ:masterfrom
sp1thas:slack-webhook-secret-on-run
Oct 16, 2020
Merged

specify slack webhook_secret on runtime#3522
joshmeek merged 4 commits intoPrefectHQ:masterfrom
sp1thas:slack-webhook-secret-on-run

Conversation

@sp1thas
Copy link
Copy Markdown

@sp1thas sp1thas commented Oct 16, 2020

Summary

Specify the webhook_secret of the SlackTask on runtime.

Changes

This PR changes the SlackTask.run method by adding the webhook_secret argument.

Importance

User will have the ability to provide the slack webhook_secret dynamically based previous tasks.

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2020

Codecov Report

Merging #3522 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

@joshmeek
Copy link
Copy Markdown

joshmeek commented Oct 16, 2020

@sp1thas Do you mind if I push another change to this branch? Now is a good time to also introduce setting the webhook URL via an upstream PrefectSecret task and I want to expose that functionality 🙂

@sp1thas
Copy link
Copy Markdown
Author

sp1thas commented Oct 16, 2020

@joshmeek sure, feel free to improve this functionality

@joshmeek joshmeek merged commit 8fc748f into PrefectHQ:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants