specify slack webhook_secret on runtime#3522
Merged
joshmeek merged 4 commits intoPrefectHQ:masterfrom Oct 16, 2020
sp1thas:slack-webhook-secret-on-run
Merged
specify slack webhook_secret on runtime#3522joshmeek merged 4 commits intoPrefectHQ:masterfrom sp1thas:slack-webhook-secret-on-run
joshmeek merged 4 commits intoPrefectHQ:masterfrom
sp1thas:slack-webhook-secret-on-run
Conversation
|
@sp1thas Do you mind if I push another change to this branch? Now is a good time to also introduce setting the webhook URL via an upstream PrefectSecret task and I want to expose that functionality 🙂 |
Author
|
@joshmeek sure, feel free to improve this functionality |
joshmeek
approved these changes
Oct 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Specify the
webhook_secretof theSlackTaskon runtime.Changes
This PR changes the
SlackTask.runmethod by adding thewebhook_secretargument.Importance
User will have the ability to provide the slack
webhook_secretdynamically based previous tasks.Checklist
This PR:
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)