RenameFlowRunTask: use default flow_run_id value from context #3548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Thanks for picking up this issue. Note that the |
zanieb
reviewed
Oct 20, 2020
zanieb
reviewed
Oct 20, 2020
zanieb
reviewed
Oct 20, 2020
# Conflicts: # tests/tasks/prefect/test_flow_run_rename.py
Co-authored-by: Michael Adkins <madkinszane@gmail.com>
Co-authored-by: Michael Adkins <madkinszane@gmail.com>
…m:sp1thas/prefect into default_flow_run_id_for_renameflowruntask
zanieb
approved these changes
Oct 20, 2020
| @@ -30,24 +31,30 @@ def __init__( | |||
| def run(self, flow_run_id: str, flow_run_name: str) -> bool: | |||
| """ | |||
| Args: | |||
| - flow_run_id (str, optional): The ID of the flow run to rename | |||
| - flow_run_id (str, optional): The ID of the flow run to rename. If `None`, | |||
There was a problem hiding this comment.
Technically an empty string will trigger a context lookup too
Suggested change
| - flow_run_id (str, optional): The ID of the flow run to rename. If `None`, | |
| - flow_run_id (str, optional): The ID of the flow run to rename. If empty, |
jcrist
approved these changes
Oct 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use default
flow_run_idvalue forRenameFlowRunTaskfrom context. More details: #3535Changes
RenameFlow.runwill useflow_run_idfrom context if is not provided.Importance
This PR will simplify the usage of
RenameFlowRunTaskby makingflow_run_idparameter optional.I'm not sure about the added test, take a closer look :)
Checklist
This PR:
changes/directory (if appropriate)docs/outline.tomlfor API reference docs (if appropriate)