Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support passing helper_script to ShellTask/DBTShellTask at runtime #3729

Merged
merged 3 commits into from
Nov 30, 2020

Conversation

sp1thas
Copy link

@sp1thas sp1thas commented Nov 29, 2020

Summary

The purpose of this PR is to allow user to pass helper_script to ShellTask/DBTShellTask on runtime.

Changes

This PR changes ShellTask.run, DBTShellTask.run and adds an extra test for ShellTask

Importance

Makes shell and dbt task more flexible on runtime. This PR solves #3716

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #3729 (ce3a401) into master (2100b03) will not change coverage.
The diff coverage is 100.00%.

Copy link

@jcrist jcrist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants