Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Support default value on DatetimeParameter #5541

Conversation

sp1thas
Copy link

@sp1thas sp1thas commented Mar 12, 2022

Summary

The purpose of this PR is to support a default value on DatetimeParameter. This PR is based on #4731

Closes #5448

Changes

This PR changes the prefect.core.parameter.DateTimeParameter

Importance

This PR is important because a default value will be supported on DateTimeParameter too.

Checklist

This PR:

  • adds new tests (if appropriate)
  • adds a change file in the changes/ directory (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

@sp1thas sp1thas requested a review from zanieb as a code owner March 12, 2022 23:40
Copy link
Contributor

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing!

@zanieb zanieb merged commit c44452b into PrefectHQ:master Mar 31, 2022
@sp1thas sp1thas deleted the feat/support-default-value-on-datetimeparameter branch March 31, 2022 15:19
lance0805 pushed a commit to hyl2015/prefect that referenced this pull request Aug 2, 2022
* add default values to datetime parameters

* reformat with black

* updated local black and reformatted test_flow

* support default value on `DatetimeParemeter`

* rename changelog file

* modify changelog

Co-authored-by: Joshua Wang <hello@wangjoshuah.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default option for DateTimeParameter
3 participants