Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_submitted for states #944

Merged
merged 6 commits into from Apr 18, 2019
Merged

Add is_submitted for states #944

merged 6 commits into from Apr 18, 2019

Conversation

zdhughes
Copy link

@zdhughes zdhughes commented Apr 18, 2019

Thanks for contributing to Prefect!

Please describe your work and make sure your PR:

  • adds new tests (if appropriate)
  • updates CHANGELOG.md (if appropriate)
  • updates docstrings for any new functions or function arguments, including docs/outline.toml for API reference docs (if appropriate)

Note that your PR will not be reviewed unless all three boxes are checked.

What does this PR change?

This PR adds the is_submitted method for states.

Why is this PR important?

This PR makes it easier to detect if a state is submitted.

@marvin-robot
Copy link
Member

Here I am, brain the size of a planet and they ask me to welcome you to Prefect.

So, welcome to the community @zdhughes! 🎉 🎉

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #944 into master will increase coverage by <.01%.
The diff coverage is 100%.

Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the new is_submitted method to the method tests here: https://github.com/PrefectHQ/prefect/blob/master/tests/engine/test_state.py#L290 ?

Thanks!!

@zdhughes zdhughes requested a review from cicdw April 18, 2019 16:31
cicdw
cicdw previously approved these changes Apr 18, 2019
Copy link
Member

@cicdw cicdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @zdhughes !

@cicdw cicdw merged commit b45cdfd into master Apr 18, 2019
@cicdw cicdw deleted the add-is-submitted-for-states branch April 18, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants