Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup nginx to run on rootless mode #946

Merged
merged 4 commits into from Jul 21, 2021

Conversation

davzucky
Copy link
Contributor

PR Checklist:

  • [x ] add a short description of what's changed to the top of the CHANGELOG.md
  • [x ] add/update tests (or don't, for reasons explained below)

Describe this PR

They are more and more people running prefect server on rootless environment on Kubernetes. Some people complain about it on the slack channel .
This change force nginx to run on root less mode

@TylerWanner
Copy link
Contributor

it is great to change to rootless--should we instead just use this base image? https://github.com/nginxinc/docker-nginx-unprivileged

@davzucky
Copy link
Contributor Author

it is great to change to rootless--should we instead just use this base image? https://github.com/nginxinc/docker-nginx-unprivileged

I don't have any preference. The result would be the same. I know this is what we are using today to customize the base ui image to rootless.

I can change to use the base nginx rootless image if you prefer

@znicholasbrown
Copy link
Contributor

I think that makes more sense @davzucky - would you mind changing the base image?

@davzucky
Copy link
Contributor Author

pushed the change to use nginxinc/nginx-unprivileged:stable as a base image

@znicholasbrown
Copy link
Contributor

LGTM @davzucky 👍🏻 !

@znicholasbrown znicholasbrown merged commit caaad3c into PrefectHQ:master Jul 21, 2021
@TylerWanner
Copy link
Contributor

thanks @davzucky !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants