Bookmarklet chopping out NYTimes text #900

Open
chrisaldrich opened this Issue Mar 1, 2017 · 5 comments

Comments

Projects
None yet
3 participants
@chrisaldrich
Contributor

chrisaldrich commented Mar 1, 2017

When nominating/drafting from NYTimes stories, typically the first several graphs are excised or not copied over into the post.

Based on some quick experiments it appears that the portion of stories that appears before </div><!-- close story-body --> (typically followed by some advertising before the story resumes) are the ones being left out for some reason. From the bookmarklet's point of view NYT articles seem to begin with the portion <p id="story-continues-2" class="story-body-text story-content" rather than the true start of the article.

Given that the Mercury browser plugin doesn't exhibit this behavior, I suspect it's something to do with the bookmarklet's JS?

This is occurring in 4.2.2 and earlier versions of the bookmarklet. I'm seeing it in Chrome as well as Firefox, so it doesn't seem to be browser dependent.

If pre-highlighting text in the browser, one does get the typical blockquoted portion of a Press This bookmarklet output.

@AramZS

This comment has been minimized.

Show comment
Hide comment
@AramZS

AramZS Mar 17, 2017

Member

We'll add these divs to our Readability checks

Member

AramZS commented Mar 17, 2017

We'll add these divs to our Readability checks

@AramZS AramZS added this to the 4.3.x milestone Mar 21, 2017

@AramZS AramZS modified the milestones: 4.2.x patch 2, 4.3.x May 22, 2017

@AramZS AramZS added this to In Process in BugFixes May 22, 2017

@AramZS AramZS moved this from In Process to Awaiting Review in BugFixes May 22, 2017

@regan008

This comment has been minimized.

Show comment
Hide comment
@regan008

regan008 May 22, 2017

Contributor

I'm still seeing this be an issue.

Here is an example: https://www.nytimes.com/2017/05/22/briefing/donald-trump-ford-motor-twin-peaks.html?&hp&action=click&pgtype=Homepage&clickSource=story-heading&module=second-column-region&region=top-news&WT.nav=top-news&_r=0

The bookmarklet grabs the first part of the story and then stops where the ad is (halfway through the second bullet point).

Contributor

regan008 commented May 22, 2017

I'm still seeing this be an issue.

Here is an example: https://www.nytimes.com/2017/05/22/briefing/donald-trump-ford-motor-twin-peaks.html?&hp&action=click&pgtype=Homepage&clickSource=story-heading&module=second-column-region&region=top-news&WT.nav=top-news&_r=0

The bookmarklet grabs the first part of the story and then stops where the ad is (halfway through the second bullet point).

@regan008 regan008 moved this from Awaiting Review to TODO in BugFixes May 22, 2017

@AramZS AramZS moved this from TODO to In Process in BugFixes May 22, 2017

@AramZS AramZS moved this from In Process to Awaiting Review in BugFixes May 23, 2017

@AramZS

This comment has been minimized.

Show comment
Hide comment
@AramZS

AramZS May 23, 2017

Member

Should be resolved by the CNN-related changes.

Member

AramZS commented May 23, 2017

Should be resolved by the CNN-related changes.

@regan008

This comment has been minimized.

Show comment
Hide comment
@regan008

regan008 May 23, 2017

Contributor

@AramZS I'm still seeing this issue occur.

Contributor

regan008 commented May 23, 2017

@AramZS I'm still seeing this issue occur.

@regan008 regan008 added the bug label May 23, 2017

@regan008 regan008 moved this from Awaiting Review to In Process in BugFixes May 23, 2017

@AramZS

This comment has been minimized.

Show comment
Hide comment
@AramZS

AramZS May 24, 2017

Member

This is unavoidable until we move to a fully JS bookmarklet. Just the nature of those particular articles.

Member

AramZS commented May 24, 2017

This is unavoidable until we move to a fully JS bookmarklet. Just the nature of those particular articles.

@AramZS AramZS modified the milestones: 4.3.x, 4.2.x patch 2 May 24, 2017

@AramZS AramZS removed this from In Process in BugFixes May 24, 2017

@AramZS AramZS modified the milestones: 4.3.x, 5.2 Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment