feat(auth): add GET /auth/portal-logout for cross-app logout chain#11
Open
awais786 wants to merge 1 commit into
Open
feat(auth): add GET /auth/portal-logout for cross-app logout chain#11awais786 wants to merge 1 commit into
awais786 wants to merge 1 commit into
Conversation
9e928f2 to
9f85990
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds `GET /auth/portal-logout?next=` so the foss-server-bundle portal's "Log out of all apps" button can include Twenty in its cross-origin redirect chain.
Same pattern as Plane twentyhq#35 / Outline twentyhq#24 / Penpot twentyhq#24 / SurfSense twentyhq#24.
Behaviour
`GET /auth/portal-logout?next=<absolute_url>`:
Files
Net: 4 files, +213 lines.
Tests
10 unit cases:
Force-logout note
GET endpoint is reachable via `
`. Impact for Twenty: clears the current browser's `tokenPair` cookie. The SPA's next request bootstraps via `/auth/sso/proxy-login` and gets a fresh tokenPair — so the user is auto-relogged in unless oauth2-proxy was also cleared.
This is lighter than SurfSense's portal-logout (which revokes refresh tokens) — appropriate for Twenty's JWT model where `tokenPair` isn't a long-lived refresh token.
Out of scope