Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHP 7.1+ support with Guzzle 5 #2

Merged
merged 4 commits into from Jul 5, 2019

Conversation

@Progi1984
Copy link

commented Jul 3, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets Relative to Prestashop\Prestashop#13761
License Apache License 2.0

@Progi1984 Progi1984 requested a review from PrestaShop/prestashop-core-developers Jul 4, 2019

@PierreRambaud

This comment has been minimized.

Copy link

commented Jul 4, 2019

One more review and merge if it's ok!

@matks

This comment has been minimized.

Copy link

commented Jul 4, 2019

Looks good 👍

Can you also add this (asked by Antoine for the compliance topic)

  • change the name of the library in the headers, readme, etc. but keep the original name where needed in the code for retro-compatibility.
  • add a paragraph in the main readme.md to explain that the name is kept for the transition for retro-compatibility purpose.

Maybe in another PR 🤔in order to keep topics split

@matks

matks approved these changes Jul 4, 2019

@matks matks merged commit bc80deb into 1.3 Jul 5, 2019

2 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
@matks

This comment has been minimized.

Copy link

commented Jul 5, 2019

Merged,

- change the name of the library in the headers, readme, etc. but keep the original name where needed in the code for retro-compatibility.
- add a paragraph in the main readme.md to explain that the name is kept for the transition for retro-compatibility purpose.

Can be done in another PR

@PierreRambaud PierreRambaud deleted the prestashop/issue13761 branch Jul 5, 2019

@matks

This comment has been minimized.

Copy link

commented Jul 22, 2019

@ttoine Current source code file header is:

<?php
/*
 * This file is part of the CsaGuzzleBundle package
 *
 * (c) Charles Sarrazin <charles@sarraz.in>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code
 */

Do we keep it ? Do we keep it and add PrestaShop as a 2nd contributor ? Do we replace it with PrestaShop header ?

@ttoine

This comment has been minimized.

Copy link

commented Jul 22, 2019

please add a 2nd contributor to make it clear who and why you modified it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.