Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOM-2409] sort by price sorts only products on this page but not in whole category #10010

Closed
prestonBot opened this issue Aug 23, 2018 · 25 comments

Comments

@prestonBot
Copy link
Collaborator

@prestonBot prestonBot commented Aug 23, 2018

This issue has been migrated from the Forge. Read the original ticket here.

  • Reporter: icydrago
  • Created at: Fri, 10 Feb 2017 21:48:38 +0100

When you have products with attributes for some pages in category and select sort by price, sorting is absolutely unexpected.

  • How to reproduce the issue ?

All my products have 2 attributes that effects on price. Combination with the lowest price set as default.


With my other products with 2 other atributes sorting is normal...


I can give access to see this issue.

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: vincentbz
  • Created at: Mon, 13 Feb 2017 11:53:52 +0100

Salut,

Est ce que tu pourrais essayer de reproduire stp ?

Merci !

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: byangui
  • Created at: Mon, 13 Feb 2017 18:13:41 +0100

Salut Vincent Beudez,

Oui j'ai pu reproduire le bug.

Scénario de reproduction de bug:
1- Installer PrestaShop
2- Accéder à la page des produits affichés par catégorie en Front Office
Par défaut, il y a 7 produits de démo dont deux articles :

  • Robe d'été imprimée (ref: demo_5) : prix = 36.6 € et réduit de 5% => Prix = 34.77 €
  • Robe d'été imprimée (ref: demo_6) : prix = 36.6 € (pas de réduction)
    3 - Faire un tri par prix décroissant => le tri se passera bien : demo_6 apparaît avant demo_5
    4 - Rendre le nombre de produits par page (en BO) égal à 2
    5 - demo_5 sera dans la page 1 et demo_6 dans la page 2 : la réduction n'a plus d'effet

NB: Le bug existe actuellement dans la branche develop

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: aleeks
  • Created at: Fri, 17 Feb 2017 14:19:23 +0100

Hello,
comment tu as fais Basma Yangui, regarde mes deux images.

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: byangui
  • Created at: Fri, 17 Feb 2017 14:29:47 +0100

Hi Alex Sampaio,

Oui, il faut rendre le nombre de produits par page 2 et non pas 5 à l'étape 4 (c'est une faute dans mon scénario de reproduction de bug).

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: aleeks
  • Created at: Fri, 17 Feb 2017 14:55:23 +0100

Hello, de la manière de comment est construit la manière de requête, c'est pas possible de fixer ça.
La raison, c'est que le prix en promo est "trouvé" après la requête sql où l'on re-tris avec getStaticPrice... sauf qu'on est déjà limité pour la pagination.

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: icydrago
  • Created at: Fri, 17 Feb 2017 16:07:57 +0100

Sorting from low to high price on every single page is normal. But the second and other pages have products with lower price than the highest on first page.

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: x-us
  • Created at: Mon, 22 Jan 2018 13:20:35 +0100

It is probably the same as

http://forge.prestashop.com/browse/PSCSX-7452

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: alban.legout
  • Created at: Wed, 11 Apr 2018 10:05:21 +0200

see ps_facetedsearch module

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: fabiorme
  • Created at: Wed, 11 Jul 2018 13:30:21 +0200

I had read that the problem would be solved in version 1.7.4, unfortunately it is not so, even in this version the products are sorted by price on the single page and not in the whole category, we know when the problem will be solved?

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: khouloud.belguith
  • Created at: Wed, 11 Jul 2018 14:18:59 +0200

Hi Fabio Ruggeri,

There are some major issues to solve before this one.
So, it will probably not solved right now.
But PrestaShop is an open source project, so it can be solved before if someone submits a pull request to solve it.

Best regards, Khouloud

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: khouloud.belguith
  • Created at: Tue, 24 Jul 2018 12:16:19 +0200

Hi icydrago,

I did not manage to reproduce the issue with the last version 1.7.4.1/ develop branch & the Faceted search v2.1.2.

Thanks to check this issue with the last version and feedback.

Best regards, Khouloud

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: javiermc
  • Created at: Fri, 27 Jul 2018 06:54:28 +0200

Hi Khouloud BELGUITH.

I think the problem comes from the specific prices and the sort by price.
I did video, maybe help you.

http://recordit.co/CRSLVlVvHz (no audio)

I come of related incident: http://forge.prestashop.com/browse/BOOM-4665.

Best regards, Javier.

 

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: marion_francois
  • Created at: Fri, 27 Jul 2018 10:21:52 +0200

Hello Khouloud BELGUITH

Please look screenrecord3.mkv it's on 1.7.4.1 and it happens also with simple product

And I have uninstalled faceted search module, so it's not related to this module

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

@prestonBot prestonBot commented Aug 23, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: khouloud.belguith
  • Created at: Fri, 27 Jul 2018 12:35:54 +0200

Hi Marion F,

New fresh install 1.7.4.1 => OK (faceted search module installed => OK / faceted search module uninstalled => OK)
https://drive.google.com/file/d/1ZlYYAuIZhg29kM_GlMWPVHVM05hy2ojX/view

Best regards, Khouloud

@marionf marionf modified the milestones: 1.7.1.0, 1.7.5.0 Aug 23, 2018
@marionf marionf added this to To do in PrestaShop 1.7.5 Aug 24, 2018
@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Aug 24, 2018

@PierreRambaud you are assigned for the ticket on the forge. Are you still assigned to this Issue ?

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

@PierreRambaud PierreRambaud commented Aug 24, 2018

@matks Not really, I never reproduce the bug with latest version of faceted search, thinking this one was closed.

@matks matks self-assigned this Aug 28, 2018
@colinegin colinegin moved this from To do to Up next in PrestaShop 1.7.5 Sep 13, 2018
@colinegin

This comment has been minimized.

Copy link
Collaborator

@colinegin colinegin commented Sep 13, 2018

Issue is a lot more complex than expected, it needs a lot of work to be done.

@colinegin colinegin removed this from the 1.7.5.0 milestone Sep 13, 2018
@colinegin colinegin added this to the 1.7.6.0 milestone Sep 21, 2018
@colinegin colinegin added this to To do in PrestaShop 1.7.6 via automation Oct 1, 2018
@colinegin colinegin removed this from Up next in PrestaShop 1.7.5 Oct 1, 2018
@colinegin

This comment has been minimized.

Copy link
Collaborator

@colinegin colinegin commented Oct 26, 2018

@matks do you have any idea of what could been done to fix this issue ? Last time there was no real solution.

@colinegin colinegin removed this from To do in PrestaShop 1.7.6 Oct 26, 2018
@colinegin colinegin removed this from the 1.7.6.0 milestone Oct 26, 2018
@marionf marionf removed the Topwatchers label Oct 26, 2018
@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Oct 29, 2018

@colinegin I see no "light" bug fix. To really fix the bug, I think we need to rework the internal processing of faceted search which is a heavy task.
I dont think this can be done for 1.7.5, and if we want to fix this bug for 1.7.6 we better start ... now 😅

@colinegin

This comment has been minimized.

Copy link
Collaborator

@colinegin colinegin commented Nov 5, 2018

Thanks @matks for your answer, unfortunately that's what I thought 👎
As discussed with the QA team, we will not be able to fix it for the 1.7.6 version, as we already have top watchers issues in the roadmap.

@darslu

This comment has been minimized.

Copy link

@darslu darslu commented Feb 8, 2019

Any news about this problem solution? i see it was removed from the 1.7.6.0

@marionf marionf added the To Do label Feb 11, 2019
@Saycile Saycile added this to Up next in PrestaShop 1.7.6 via automation Feb 19, 2019
@Saycile Saycile moved this from Up next to To do in PrestaShop 1.7.6 Feb 19, 2019
@prestonBot prestonBot referenced this issue Feb 20, 2019
31 of 40 tasks complete
@colinegin colinegin moved this from To do to In progress in PrestaShop 1.7.6 Feb 25, 2019
@PierreRambaud

This comment has been minimized.

Copy link
Contributor

@PierreRambaud PierreRambaud commented Feb 25, 2019

Hey @darslu, as you can see, we plan to integrate it in the 1.7.6 with the new Faceted search module :)

@colinegin colinegin moved this from In progress to Backlog in PrestaShop 1.7.6 Mar 27, 2019
@colinegin colinegin moved this from Backlog to To be tested in PrestaShop 1.7.6 Mar 29, 2019
@marionf marionf added Fixed and removed To Do labels Apr 11, 2019
@marionf marionf moved this from To be tested to To be merged in PrestaShop 1.7.6 Apr 15, 2019
@marionf marionf closed this Apr 15, 2019
PrestaShop 1.7.6 automation moved this from To be merged to Done Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
6 participants
You can’t perform that action at this time.