New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations not working #10701

Open
Prestaworks opened this Issue Sep 25, 2018 · 24 comments

Comments

Projects
None yet
3 participants
@Prestaworks
Copy link
Contributor

Prestaworks commented Sep 25, 2018

Describe the bug
The save of translations seems not to be case sensitive, the display of phrases to translate is case sensitive, so if a template has for instance the texts "add to cart" and "Add to Cart" and "Add to cart" there are three fields to translate on the front-end translations, however, only one is saved.

To Reproduce
Steps to reproduce the behavior:

  1. Install a new theme
  2. Go to translations and locate a phrase that exists in multiple case variations.
  3. change the translations and save.
  4. Reload the translationspage.

Additionnal information
PrestaShop version: 1.7.4.2
PHP version: 7.x

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 25, 2018

Hi @Prestaworks,

Have you tried to contact the theme author about this issue?

Best regards, Khouloud

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Sep 26, 2018

Hi Khouloud,

Yes, but the translation tools is a core feature in Prestashop, and all the phrases we want to translate are showing up in the translations tool but they are not saved on the correct place, instead they keep overwriting eachother and that issue is most likely in the translation section of Prestashop.

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 26, 2018

Hi @Prestaworks,

Those translations are saved in the Back office? but they are not successfully saved in the Front office?
If yes, could you please try to configure your smarty by disabling the cache, set the option "Template compilation" to Force compilation and clear cache.
Thanks to check and feedback.

Best regards, Khouloud

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Sep 26, 2018

Hi Khouloud,

The translations are saved on the wrong row in the BO

I have these three rows in BO translations

add to cart
Add to cart
Add to Cart

when I open these, I have these translations
lägg i varukorgen
empty field
Lägg i Varukorgen

In the empty field, I type "Lägg i varukorgen" and click save
When the page reloads in the BO I have these translations

Lägg i varukorgen
empty field
Lägg i Varukorgen

As you can see, the text I types in the second field, is saved on the first field.

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 26, 2018

Hi @Prestaworks,

What is the exact name of this theme?
What is the exact position of each expression?
image

Best regards, Khouloud

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Sep 26, 2018

Hi, The theme name is autopart

See attached image for locations

for_khalouhd

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 26, 2018

Hi @Prestaworks,

I used the simplio theme with the PS1.7.4.2.
In the translation page, I found only 1 expression "add to cart" not as you 3 expressions.
I attached a video record.
https://drive.google.com/file/d/1Yb6DuL8pfCh36Z9BeybAfxaKhTEXwMLx/view

Best regards, Khouloud

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Sep 26, 2018

Hi,

If you only get one option then I can't see how you are going to recreate the issue :(

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 26, 2018

Hi @Prestaworks,

As it's not the default theme, provided by Prestashop, we can't do anything with this before the feedback of the theme author.
You should contact the theme author via your addons.prestashop.com account.
Thanks!

Best regards, Khouloud

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Sep 26, 2018

Hi,

but how is the issue in the template?
should prestashop not handle multiple phrases?

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 26, 2018

Hi @Prestaworks,

Same issue with the "luxury" theme.
There's only one expression "add to cart".

Best regards, Khouloud

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Sep 26, 2018

Hi,

I have attached a childtheme for you that you can use to recreate the issue.
child1.zip

it is classic theme child theme, that only replace the contact form tpl so that you get 3 different translations. I hope this helps to recreate the issue for you.

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 26, 2018

Hi @Prestaworks,

When trying to upload your theme attached, I have this error
https://drive.google.com/file/d/14jFzlwbl2hZ_22UHYE00q1YcYFYmCVuC/view

Best regards, Khouloud

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Sep 26, 2018

just unzip it to your themes folder

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 26, 2018

Hi @Prestaworks,

No, I tried to unzip the child1 into the themes folder, but it is not displayed in the list of all the theme selected.
image

Best regards, Khouloud

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Sep 27, 2018

can you show how it looks inside your themes folder now?

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 27, 2018

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Sep 27, 2018

odd, we tried on two installations on separate machines here, works fine on both, maybe you need to clear cache?

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 27, 2018

@Prestaworks, no after clearing cache, there's no success.
Same issue!

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Sep 27, 2018

ok, maybe you can get some support at your office on how to get the child theme to install or you may have to add your own bug report to get this fixed :)

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 27, 2018

Hi @Prestaworks,

Could you please try with this theme: https://github.com/PrestaShop/childtheme-example & feedback.

Best regards, Khouloud

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Sep 27, 2018

@Prestaworks

This comment has been minimized.

Copy link
Contributor Author

Prestaworks commented Sep 27, 2018

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 27, 2018

Hi @Prestaworks,

Thanks for the clarifications.
Now I manage to reproduce the issue with PS1.7.4.2.
When there are 3 expressions with the same value.
Only the first expression will be edit successfully but with the third value.
https://drive.google.com/file/d/1Tx3HESPCpUzMEFzJLi_rUWAUQ_IZZIi8/view
@marionf What do you think?

Best regards, Khouloud

@khouloudbelguith khouloudbelguith removed the NMI label Sep 27, 2018

@marionf marionf removed their assignment Sep 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment