New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The page "Module Catalog" is not found after uninstalling the mbo module #11264

Open
khouloudbelguith opened this Issue Nov 5, 2018 · 11 comments

Comments

Projects
None yet
5 participants
@khouloudbelguith
Contributor

khouloudbelguith commented Nov 5, 2018

Describe the bug
After uninstalling the "mbo" module, I tried to navigate to the Modules => Module Catalog page.
A red alert is displayed "Page not found" with an empty page.
We need to go to the Dashboard page & reload again the Module Catalog page, to be OK.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Module Manager page
  2. Uninstall the mbo module
  3. Go to the Module Catalog page
  4. See error

Screenshots
image
https://drive.google.com/file/d/1t374pjGSzir34IPefLOshpgrNdCqd4UQ/view

Additionnal information
PrestaShop version: 1.7.5.0build4
PHP version: 7.1

@marionf

This comment has been minimized.

Contributor

marionf commented Nov 5, 2018

@MrBaiame @eternoendless
I don't know if this one should be fixed in the module or in the core ?

@jolelievre jolelievre self-assigned this Nov 7, 2018

@jolelievre jolelievre moved this from To do to In progress in PrestaShop 1.7.5 Nov 7, 2018

@jolelievre

This comment has been minimized.

Contributor

jolelievre commented Nov 7, 2018

hello, this is not really a bug

this happens when you just uninstalled the module, because the link in the menu still directs you to the (uninstalled) module
the same problem happens for any uninstalled modules (link widget for instance), because we don't update the menu
And I am not sure we should for performance issues, but it could be a new feature

Anyway when you refresh your page the link is correctly reset to the core module manager

@jolelievre jolelievre moved this from In progress to To do in PrestaShop 1.7.5 Nov 7, 2018

@marionf

This comment has been minimized.

Contributor

marionf commented Nov 8, 2018

Will it be possible to reload the page when we click on uninstall ?

@jolelievre

This comment has been minimized.

Contributor

jolelievre commented Nov 8, 2018

Yes it is possible, only it makes you lose your search if you made one
And it slows down the process if you were planning on uninstalling several modules (which doesn't happen every day I think)
But it kind of changes the feature, I don't know if we can decide this kind of changes on our own?

@marionf

This comment has been minimized.

Contributor

marionf commented Nov 8, 2018

@colinegin wdyt ?

@marionf marionf added waiting for PM TBS and removed To Do labels Nov 8, 2018

@marionf marionf removed this from To do in PrestaShop 1.7.5 Nov 8, 2018

@colinegin

This comment has been minimized.

colinegin commented Nov 8, 2018

Not sure I exactly understand, but in my opinion we should keep the catalog page even though MBO is uninstalled, is this possible @jolelievre ?

@jolelievre

This comment has been minimized.

Contributor

jolelievre commented Nov 8, 2018

Mmm, I am not sure to understand you either ^^

The native catalog page is always available, when you install MBO the link in the left side menu is replaced by the MBO catalog
So when you uninstall the module this link is no longer valid, but it is still in the menu
You just need to refresh the page for the menu to be updated with the native link

Hence our question, should we refresh the page each time a module is uninstalled in order to update the menu?

@colinegin

This comment has been minimized.

colinegin commented Nov 9, 2018

Sorry I did not get what you meant :)

We discussed with @marionf , do you think it could have a bad impact on performance if we reload a page every time a module (or several ones simultaneously) is uninstalled ?

@jolelievre

This comment has been minimized.

Contributor

jolelievre commented Nov 9, 2018

well it will take a few seconds for the page to be reloaded, is it acceptable?

@Quetzacoalt91

This comment has been minimized.

Member

Quetzacoalt91 commented Nov 9, 2018

You may uninstall several modules in a single call, but I would recommend to target 1.7.6.0 for coming back on a page refresh. The ajax requests have been implemented since PS 1.7.

@colinegin

This comment has been minimized.

colinegin commented Nov 9, 2018

Seems a lot if done for every uninstalled module.
Couldn't it be reloaded only when it detects MBO module ?

Otherwise can't we just simply add information on the page instead of the current message which is quite unclear ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment