Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug : Add to cart success without stock #11631

Closed
francoispeyret opened this issue Dec 6, 2018 · 23 comments · Fixed by #14033 or #14214

Comments

@francoispeyret
Copy link
Contributor

@francoispeyret francoispeyret commented Dec 6, 2018

Description

  1. Go to a page product with stock.
  2. In BO go to this product and update the quantity to 0.
  3. in the page page produit (without page refresh) add the product to cart.
  4. Ouch...

The product was added but it's a success for shoppingcart but it'snot in real life.

capture du 2018-12-06 10-37-27

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Dec 6, 2018

Hi @francoispeyret,

Thanks for your report.
If you click on "Proceed too checkout" button, you will be redirected to shopping cart page with a red alert "The item The best is yet to come' Framed poster in your cart is no longer available in this quantity. You cannot proceed with your order until the quantity is adjusted." & the "Proceed too checkout" is disabled so you cannot proceed your checkout.
image
Recently, we have made some changes to fix those issues:
#8752
#8774
#8607
Thanks to check & feedback.

@francoispeyret

This comment has been minimized.

Copy link
Contributor Author

@francoispeyret francoispeyret commented Dec 6, 2018

Right but the proceed was stop before that in 1.6..

image

The modal-dialog hasn't got every information of current product in this case.

no bug :
image

buged :
image

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Dec 6, 2018

@francoispeyret, thanks for your feedback.
Yes, I tried with PS1.6 & we are stopped before the redirection to shopping cart
https://drive.google.com/file/d/1pHl6_aO4IbVLQsMdDfm3c57_8aHM3I5S/view
But with PS1.7.5.0, we are redirected to the shopping cart & the alert will be displayed.
@marionf, what do you think?
Thanks!

@marionf

This comment has been minimized.

Copy link
Contributor

@marionf marionf commented Dec 10, 2018

We could add a check to verify the quantity when we click on the "add to cart" button on the product page or in the quickview
But if the product is no more available (qty <= 0 and order of out of stock products disabled) we need to specify which message we displaye and how

@marionf marionf removed their assignment Dec 10, 2018
@francoispeyret

This comment has been minimized.

Copy link
Contributor Author

@francoispeyret francoispeyret commented Dec 10, 2018

A fix can do the job.
It is only to correct the display with empty data due to controller error.

develop...francoispeyret:patch-3

@colinegin

This comment has been minimized.

Copy link
Collaborator

@colinegin colinegin commented Dec 18, 2018

Hello,

We've checked with Nadia, our recommendation would be to have the same info and display as it is currently when the product is already out of stock. See the image
capturenostock

The error message would be displayed when the client clicks on Add to cart (product page or quickview) instead of the current "broken" pop-up.

Of course, we still need to check with the dev team if it is possible to add a check to verify the quantity when we click on the "add to cart" button on the product page or in the quickview.

Have a nice day,

Coline

@francoispeyret

This comment has been minimized.

Copy link
Contributor Author

@francoispeyret francoispeyret commented Dec 18, 2018

@LouiseBonnard

This comment has been minimized.

Copy link
Contributor

@LouiseBonnard LouiseBonnard commented Dec 20, 2018

@colinegin, can you confirm that the action will be impossible to do? For the wording, I suggest There are not enough products in stock, to be localized in Shop.Notifications.Error. @TristanLDD, okay for you?

@marionf

This comment has been minimized.

Copy link
Contributor

@marionf marionf commented Jun 3, 2019

@4itsoft because your issue is for customizable product, please follow #9974

@sarahdib sarahdib added Fixed To Do and removed To Do Fixed labels Jun 6, 2019
@sarahdib sarahdib moved this from To be tested to In progress in PrestaShop 1.7.7 Jun 6, 2019
PrestaShop 1.7.7 automation moved this from In progress to Done Jun 7, 2019
@marionf marionf reopened this Jun 10, 2019
@marionf marionf moved this from Done to In progress in PrestaShop 1.7.7 Jun 10, 2019
@francoispeyret

This comment has been minimized.

Copy link
Contributor Author

@francoispeyret francoispeyret commented Jun 10, 2019

thanks @marionf

@matks matks moved this from In progress to To be tested in PrestaShop 1.7.7 Jun 24, 2019
@sarahdib sarahdib moved this from To be tested to In progress in PrestaShop 1.7.7 Jul 8, 2019
@colinegin colinegin assigned matks and unassigned colinegin and NadiaCamard Jul 15, 2019
@marionf marionf removed the To Do label Jul 18, 2019
PrestaShop 1.7.7 automation moved this from In progress to Done Jul 18, 2019
@matks matks reopened this Jul 18, 2019
@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Jul 18, 2019

Issue not yet fixed, it requires PrestaShop/ps_shoppingcart#41

@matks matks moved this from Done to To be tested in PrestaShop 1.7.7 Jul 18, 2019
@marionf marionf moved this from To be tested to To be merged in PrestaShop 1.7.7 Jul 18, 2019
@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Jul 18, 2019

Fixed by PrestaShop/ps_shoppingcart#41 and Handle shoppingcart error returns properly - part 2 #14214

@matks matks closed this Jul 18, 2019
PrestaShop 1.7.7 automation moved this from To be merged to Done Jul 18, 2019
@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Oct 30, 2019

Module ps_shoppingcart has been released on v2.0.3 which ship the related fix. So this bug is fully fixed when using PrestaShop 1.7.7.x and ps_shoppingcart 2.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.