Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Upgrade to jQuery latest, use jQuery migrate for retro compatibility #13829

Closed
eternoendless opened this issue May 17, 2019 · 5 comments
Closed

Comments

@eternoendless
Copy link
Member

@eternoendless eternoendless commented May 17, 2019

We are currently using old or very old versions of jQuery. These versions have never been upgraded because of breaking changes introduced in later versions. Using jQuery Migrate we could upgrade them to the latest version without breaking backwards compatibility.

@FredBrockstedt

This comment has been minimized.

Copy link

@FredBrockstedt FredBrockstedt commented Jun 7, 2019

There are three JS security vulnerabilities in 1.7.5.2 (and lower versions):
2 - JQuery2.2.4 - Medium
1 - JQuery UI1.10.3 - High
They are fixed in the current versions of JQuery/UI.

@eternoendless eternoendless added this to Backlog in PrestaShop 1.7.7 via automation Jul 18, 2019
@samuel-pires

This comment has been minimized.

Copy link

@samuel-pires samuel-pires commented Jul 29, 2019

To cut in 4 parts:

@matthieu-rolland

This comment has been minimized.

Copy link
Contributor

@matthieu-rolland matthieu-rolland commented Aug 22, 2019

Here is the official migration guide:

https://jquery.com/upgrade-guide/3.0/#overview

For example we already use a jquery-migrate (version 1.2.1) in the back office, and it can't be used simultaneously with jquery-migrate 3.x.

So in a nutshell, the process should be as follow:

1/ Change jquery version from 1.11 to 1.12 (minimal version supported by the migration script)

2/ Check that nothing is broken, fix when it's broken

3/ Once bugs have been fixed, change jquery version to 3.0 and add the jquery-migrate v3 jquery-migrate-3.1.0.js

4/ Check that there is no bug, update jquery libraries if needed.

@matthieu-rolland

This comment has been minimized.

Copy link
Contributor

@matthieu-rolland matthieu-rolland commented Sep 12, 2019

I added an issue to this epic: #15508

@samuel-pires samuel-pires changed the title Upgrade to jQuery latest, use jQuery migrate for retro compatibility [EPIC] Upgrade to jQuery latest, use jQuery migrate for retro compatibility Sep 24, 2019
@samuel-pires

This comment has been minimized.

Copy link

@samuel-pires samuel-pires commented Oct 11, 2019

Hi @matthieu-rolland
Are we completely done with this EPIC or are there still some related tasks to add to the EPIC?

@colinegin colinegin removed the Improvement label Oct 22, 2019
@samuel-pires samuel-pires added this to Ready for next version (1.7.7) in PrestaShop Roadmap Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
PrestaShop Roadmap
Ready for delivery (1.7.7)
6 participants
You can’t perform that action at this time.