Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression into product URL assign, for product list #14765

Closed
prestamodule opened this issue Jul 19, 2019 · 18 comments
Closed

Regression into product URL assign, for product list #14765

prestamodule opened this issue Jul 19, 2019 · 18 comments

Comments

@prestamodule
Copy link
Contributor

@prestamodule prestamodule commented Jul 19, 2019

Describe the bug
Introduced here :
48125d7

We cannot define a specific URL for the product anymore while using search engine or when splitting products by their attributes. The canonical URL is always used into the template ( cc @jolelievre )

Additional information
PrestaShop version: 1.7.6
PHP version: any

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Jul 19, 2019

Ping @jolelievre what do you think?

Thanks!

@jolelievre

This comment has been minimized.

Copy link
Contributor

@jolelievre jolelievre commented Jul 19, 2019

@prestamodule indeed this was introduced in 176 because previously on product with combinations the canonical url (without attribute) redirected to the default combination
this was bad practice for two main reasons:

  • the canonical itself was not accessible and always returned a redirect response
  • if the default combination changed then the redirection also changed so even the redirection was not very consistent

As for the listing it is better to use the canonical url so that you can have more backlinks to the canonical page But this canonical always displays the default combination by default
And even though the attribute urls are not used in listing any more they are still accessible (when you change an attribute the url is updated you can try to access them it will work) so any previous SEO ranking won't be lost but transferred to the canonical

@prestamodule

This comment has been minimized.

Copy link
Contributor Author

@prestamodule prestamodule commented Jul 19, 2019

I understand the SEO improvements. But this is not what we are complaining about here :)
For example, in our search engine module, we are presenting products with the best possible combination. Meaning that we will display a dress as red if the color is available. We are also assigning the best combination URL, so the user will get to the product page with the same image, price, etc.
From this point of view, this is a big regression regarding UX !
We just want to bring back the possibility to force a specific product URL instead of the canonical one, when needed (search engine, faceting, splitting products by their attributes groups...), as it’s the case since PrestaShop 1.5+ 🤷🏻‍♂️

@prestamodule

This comment has been minimized.

Copy link
Contributor Author

@prestamodule prestamodule commented Aug 1, 2019

any news regarding this issue ? @jolelievre ?

@jf-viguier

This comment has been minimized.

Copy link
Contributor

@jf-viguier jf-viguier commented Aug 29, 2019

any news ?

1 similar comment
@prestamodule

This comment has been minimized.

Copy link
Contributor Author

@prestamodule prestamodule commented Sep 23, 2019

any news ?

@jolelievre

This comment has been minimized.

Copy link
Contributor

@jolelievre jolelievre commented Sep 23, 2019

Hi @prestamodule,
sorry for the delay in my response. Ok, I get what you mean with specific product url and I see how it can be troublesome for the user.

Do you suggest to never use the canonical url of the product in listing then? And instead always use product.url in the templates? I wonder if we should have a setting for this behaviour or if we can force it for everyone.

Either way I guess this won't have drawbacks on SEO since all the product combinations have the same canonical anyway.

@colinegin @marionf what do you think of reverting these modifications?
48125d7#diff-f2a39218feae4cfb78f374d5c0909a9cR30

@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Sep 23, 2019

It seems we're going back-and-forth on these SEO topics 😐maybe we should stop forcing one behavior or another one, and provide options to choose the behavior ? Provide a small configuration panel in "Trafic & SEO" BO page to choose which url to use in the listing ?

@prestamodule

This comment has been minimized.

Copy link
Contributor Author

@prestamodule prestamodule commented Sep 23, 2019

@matks @jolelievre That could be an option, but as it's a very little modification into the template, and really specific, i don't think that this is necessary (and also, users will have to wait for 1.7.7...).
We do not think that there will be impact on SEO as the canonical URL is already exposed when you are on the product page.

@jolelievre

This comment has been minimized.

Copy link
Contributor

@jolelievre jolelievre commented Sep 23, 2019

As @prestamodule I don't think the impact will be huge on SEO, if it's just reverting the change I'm sure we can integrate it in 1762, however if this needs to be managed via a configuration this needs to be validated by the product team
Which is why I'd like an input from them @PrestaShop/prestashop-product-team :)
Also @colinegin maybe we should validate the SEO impact with our SEO consultant.

By the way @prestamodule could you detail a test scenario please, like which kind of product create and what kind of research perform so that the QA team can test and validate it?
Does this problem only occurs when researching with facetedsearch? or is it more generic?

Thank you

@xiaoyuan1998

This comment has been minimized.

Copy link

@xiaoyuan1998 xiaoyuan1998 commented Sep 24, 2019

i have same issue, and + the social network share the bad url without attribute
#15655

Thanks

@colinegin colinegin added this to Backlog in PrestaShop 1.7.6 via automation Oct 14, 2019
@jolelievre jolelievre moved this from Backlog to To do in PrestaShop 1.7.6 Oct 14, 2019
@jf-viguier

This comment has been minimized.

Copy link
Contributor

@jf-viguier jf-viguier commented Oct 15, 2019

What have you decided here ?

@xiaoyuan1998

This comment has been minimized.

Copy link

@xiaoyuan1998 xiaoyuan1998 commented Oct 15, 2019

@jf-viguier

This comment has been minimized.

Copy link
Contributor

@jf-viguier jf-viguier commented Oct 15, 2019

@xiaoyuan1998 ok, mais je posait la question à la team prestashop pour le core.
Il y a vraiement des modules pour tout !

@jf-viguier

This comment has been minimized.

Copy link
Contributor

@jf-viguier jf-viguier commented Oct 15, 2019

@colinegin @jolelievre we just had a discussion with @prestamodule and we agreed that the best solution for now is to revert to this to avoid regression :
48125d7#diff-f2a39218feae4cfb78f374d5c0909a9cR30

For me, there is no need for an extra parameter : the perfect solution is to have a product url without combinaison : it's already implemented in ps : just remove the default combinaison and you'll see.

@xiaoyuan1998

This comment has been minimized.

Copy link

@xiaoyuan1998 xiaoyuan1998 commented Oct 15, 2019

@xiaoyuan1998 ok, mais je posait la question à la team prestashop pour le core.
Il y a vraiement des modules pour tout !

I spent 90 euros for the addone (pretty url):( but at least it works

@colinegin

This comment has been minimized.

Copy link
Collaborator

@colinegin colinegin commented Oct 15, 2019

Hello @jf-viguier ,

sorry this issue is still in progress as we are currently discussing with @jolelievre and a SEO expert, to be sure we do not introduce any SEO regression, while taking into account prestamodule's problem.
We will take a decision asap and keep you updated !

@jolelievre jolelievre moved this from To be reviewed to To be tested in PrestaShop 1.7.6 Oct 15, 2019
@jolelievre jolelievre self-assigned this Oct 15, 2019
@Robin-Fischer-PS Robin-Fischer-PS moved this from To be tested to To be merged in PrestaShop 1.7.6 Oct 16, 2019
@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.6.2 milestone Oct 16, 2019
@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Oct 16, 2019

Fixed by #15964

Thanks @prestamodule, @jf-viguier and @xiaoyuan1998 for helping us on this matter

@matks matks closed this Oct 16, 2019
PrestaShop 1.7.6 automation moved this from To be merged to Done Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.