Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#13440 creates a small BC break #14846

Closed
rdy4ever opened this issue Jul 24, 2019 · 4 comments

Comments

@rdy4ever
Copy link
Contributor

commented Jul 24, 2019

Describe the bug
One little BC problem introduced in #13440 : when using a theme that doesn't include the button added in personal-information.tpl (from add-ons or other custom theme, or even Classic whithout the 1.7.6 update), if the user clicks on step one from another step (after step 1 is completed), then there's no way for him to go back (or forward, te be exact) to the next step, as this button is missing and he cannot click on the other steps. So he gets stuck and needs to refresh the page.

To Reproduce
Steps to reproduce the behavior:
Remove the button code from themes/classic/templates/checkout/_partials/steps/personal-information.tpl, so the file is as before #13440 and use the check-out. After completing step 1 as a logged-in user (create account, don't use the guest check-out), click on it to go back (as if you'd like to change personal info), but without the new Continue button you'll get stuck, no longer being able to continue to the next steps.

Note: Use the check-out as logged-in user, not as guest.

Screenshots
If applicable, add screenshots or screenrecords to help explain your problem.

Additional information
PrestaShop version: 1.7.6
PHP version: N/A

@rdy4ever

This comment has been minimized.

Copy link
Contributor Author

commented Jul 24, 2019

@matks

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

Hi @rdy4ever, thanks for the feedback ! @jolelievre is on vacations but we'll review this as BC breaks in the FO theme are a very important issue

@marionf marionf added this to Backlog in PrestaShop 1.7.6 via automation Aug 6, 2019

@marionf

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

@PrestaShop/prestashop-core-developers should we fix it in 1.7.6.1 ?

@jolelievre

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Hi @marionf yes I guess we should look for a way to avoid this BC break.

@eternoendless eternoendless moved this from Backlog to To do in PrestaShop 1.7.6 Aug 8, 2019

@jolelievre jolelievre moved this from To do to In progress in PrestaShop 1.7.6 Aug 8, 2019

@jolelievre jolelievre self-assigned this Aug 8, 2019

@jolelievre jolelievre moved this from In progress to To be reviewed in PrestaShop 1.7.6 Aug 8, 2019

@marionf marionf added the Minor label Aug 9, 2019

@marionf marionf moved this from To be reviewed to To be tested in PrestaShop 1.7.6 Aug 9, 2019

@marionf marionf moved this from To be tested to In progress in PrestaShop 1.7.6 Aug 9, 2019

@jolelievre jolelievre moved this from In progress to To be reviewed in PrestaShop 1.7.6 Aug 9, 2019

@matks matks moved this from To be reviewed to To be tested in PrestaShop 1.7.6 Aug 12, 2019

@eternoendless eternoendless moved this from To be tested to Done in PrestaShop 1.7.6 Aug 12, 2019

@marionf marionf closed this Aug 12, 2019

@marionf marionf added Fixed and removed To Do labels Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.