Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing a theme that has a translations folder but no files in it will throw an exception #14960

Closed
eternoendless opened this issue Aug 1, 2019 · 1 comment

Comments

@eternoendless
Copy link
Member

commented Aug 1, 2019

Describe the bug
When loading a theme, ThemeManager will try to load its translations if the translations directory is present. But if it's present AND empty it would throw an exception.

To Reproduce
Steps to reproduce the behavior:

  1. Create a theme that is not named classic, make sure there's a translations directory in it with nothing inside.
  2. Zip it
  3. Try to import it into PS.

Additional information
PrestaShop version: 1.7.6.0
PHP version: 7.1

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Aug 6, 2019

Hi @eternoendless,

I tried to import a theme with nothing inside the translations directory.
I have this error
image
I tried also with a child theme => Same behavior
childtheme-example.zip

Only this error, without exception.
=> issue created #15004
Thanks!

@khouloudbelguith khouloudbelguith added this to the 1.7.6.1 milestone Aug 6, 2019

@khouloudbelguith khouloudbelguith moved this from To be tested to To be merged in PrestaShop 1.7.6 Aug 6, 2019

PrestaShop 1.7.6 automation moved this from To be merged to Done Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.