Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When you are in all shop context all categories are not displayed in product page #15274

Closed
sitte opened this issue Aug 27, 2019 · 4 comments
Closed

Comments

@sitte
Copy link
Contributor

@sitte sitte commented Aug 27, 2019

Describe the bug
I have multisore, each store has it's own category branch, all stores has the same products.
When editing product in "all shops" context, category assigment block shows categories only from one store. In Prestashop 1.5.4.1 I see all category branches from all shops.

After saving it overrides main category in all shops.

To Reproduce
Steps to reproduce the behavior:

  1. Activate multistore, make 2 stores A and B
  2. Make 2 categories CatA and CatB
  3. Assign CatA to Store A and Cat B to Store B
  4. Ad one product to CatA and CatB
  5. Try to edit this product in "all shops context" and check what categories You see.
  6. Try to save the product and check what is stored in ps_product_shop.id_category_default for this product

Additional information
PrestaShop version: 1.7.6
PHP version: 7.2

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Aug 27, 2019

Hi @sitte,

Thanks for your report.
Following these steps:

  1. Activate multistore, make 2 stores A and B
  2. Make 2 categories CatA and CatB
  3. Assign CatA to Store A and Cat B to Store B
  4. All shops context is selected => Add new product => CatB is not displayed in the list of categories
    => It is not the same behavior as PS1.7.5.2

PS1.7.6.0/PS1.7.6.1:

image
PS1.7.5:
image

This is a regression.

Try to save the product and check what is stored in ps_product_shop.id_category_default for this product

I have the same behavior as PS1.7.5 & PS1.7.6
Because when All shops context is selected => We have only a default category is selected.
I’ll add this to the debug roadmap so that it’s fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!
Thanks!

@sitte

This comment has been minimized.

Copy link
Contributor Author

@sitte sitte commented Aug 27, 2019

I see 2 problems:

  1. in "all shops" context we should see all category branches from all stores, not from default store.
  2. in "all shops" context there should be main category per shop not per multistore

I can try to fix 1. Can You point me in direction where are functions that load category structure, it would speed up the process?

I think that 2 needs not only change of loaded data but in addition change of interface - not one radio button but one for each store.

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Aug 27, 2019

@sitte, we should ask developers: @PrestaShop/prestashop-core-developers

@marionf marionf added this to Backlog in PrestaShop 1.7.6 via automation Aug 28, 2019
@marionf marionf changed the title Editing product in multistore overrides main category assigment When you are in all shop context all categories are not displayed in product page Sep 12, 2019
@prestonBot prestonBot mentioned this issue Sep 12, 2019
2 of 70 tasks complete
@PierreRambaud PierreRambaud moved this from Backlog to To do in PrestaShop 1.7.6 Sep 17, 2019
@PierreRambaud PierreRambaud self-assigned this Sep 17, 2019
@PierreRambaud PierreRambaud moved this from To do to In progress in PrestaShop 1.7.6 Sep 18, 2019
@PierreRambaud PierreRambaud moved this from In progress to To be reviewed in PrestaShop 1.7.6 Sep 23, 2019
@jolelievre jolelievre moved this from To be reviewed to To be tested in PrestaShop 1.7.6 Sep 26, 2019
@matks matks removed the To Do label Oct 7, 2019
@Robin-Fischer-PS Robin-Fischer-PS moved this from To be tested to To be merged in PrestaShop 1.7.6 Oct 10, 2019
@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Oct 10, 2019

Fixed by #15621 (comment)

@matks matks closed this Oct 10, 2019
PrestaShop 1.7.6 automation moved this from To be merged to Done Oct 10, 2019
@marionf marionf added this to the 1.7.6.2 milestone Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.