Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ps_emailsubscription 2.5 does not register e-mail in its database #15425

Closed
pierreloicq opened this issue Sep 5, 2019 · 8 comments

Comments

@pierreloicq
Copy link

@pierreloicq pierreloicq commented Sep 5, 2019

With PS 1761, I upgraded the Newsletter subscription module from 2.3 to 2.5 as proposed in the Module manager/updates tab.
2.3 was working fine, but with 2.5, e-mail is not saved in the db, and there is no "well received" green message below the e-mail box. I am just sent to index.php#footer when I submit an e-mail.

I also have an error popping up when I go on the module config page :

Notice on line 74 in file C:\\Program Files (x86)\\Ampps\\www\\presta17\\src\\Adapter\\Routing\\LegacyHelperLinkBuilder.php
[8] Undefined index: id_merged

To sum it up

  • minor bug: "no 'well received' green message below the e-mail box"
  • major bug: "e-mail is not saved in the db"

Additional information
PrestaShop version: 1761
PHP version: 7.1

Thank you

@pierreloicq pierreloicq changed the title Bug ps_emailsubscription 2.5 ps_emailsubscription 2.5 des not register e-mail in its database Sep 5, 2019
@pierreloicq pierreloicq changed the title ps_emailsubscription 2.5 des not register e-mail in its database ps_emailsubscription 2.5 does not register e-mail in its database Sep 5, 2019
@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Sep 5, 2019

Hi @pierreloicq,

About the red alert.
Here's the PR: #15382 to fix the issue.
It is reported in this ticket:
#15318
About the seond issue, I manage to reproduce the issue with ps_emailsubscription v2.5.0 & PS1.7.6.1.
With ps_emailsubscription v2.3.0 => OK
With 1.7.6.0 & ps_emailsubscription v2.5.0 => NOK
With develop branch & ps_emailsubscription v2.5.0 => OK
https://drive.google.com/file/d/1CWadNE_yirc7ujoj58_jAQ9055a-OAOH/view
I’ll add this to the debug roadmap so that it’s fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!
Thanks!

@marionf

This comment has been minimized.

Copy link
Contributor

@marionf marionf commented Sep 17, 2019

@khouloudbelguith is it a regression of 1.7.6.0 or of ps_emailsubscription 2.5.0 ?
Do you have it with PS 1.7.5.2 & ps_emailsubscription 2.5.0 ?

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Sep 17, 2019

@marionf, it is a module regression.
Same issue with PS1.7.5.2 & ps_emailsubscription 2.5.0.

Thanks!

@marionf marionf added this to To do in Native modules integration via automation Sep 17, 2019
@marionf marionf added the Major label Sep 17, 2019
@marionf

This comment has been minimized.

Copy link
Contributor

@marionf marionf commented Sep 17, 2019

It was working also with ps_emailsubscription 2.4.0, so it's well a regression of 2.5.0
@Progi1984 FYI

@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Sep 18, 2019

Found the issue, indeed it works on develop (= it works with PS > 1.7.7) thanks to PR #14937

@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Sep 18, 2019

@pierreloicq a fix is on its way, see PrestaShop/ps_emailsubscription@f0c60d4

@matks matks removed the To Do label Sep 18, 2019
@matks matks moved this from To do to To be reviewed in Native modules integration Sep 18, 2019
@marionf marionf moved this from To be reviewed to To be tested in Native modules integration Sep 18, 2019
@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Sep 20, 2019

I did a full summary of all possible configurations in #15629

@sarahdib sarahdib added the Fixed label Sep 25, 2019
@sarahdib sarahdib moved this from To be tested to To be merged in Native modules integration Sep 25, 2019
@marionf marionf closed this Sep 30, 2019
Native modules integration automation moved this from To be merged to Done Sep 30, 2019
@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Sep 30, 2019

Bug fixed on dev branch of https://github.com/PrestaShop/ps_emailsubscription/
Release in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
5 participants
You can’t perform that action at this time.