Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct access to customer's view missing from Customers list row #15831

Closed
samuel-pires opened this issue Oct 4, 2019 · 6 comments
Closed

Direct access to customer's view missing from Customers list row #15831

samuel-pires opened this issue Oct 4, 2019 · 6 comments

Comments

@samuel-pires
Copy link

@samuel-pires samuel-pires commented Oct 4, 2019

Describe the bug
In Customers > Customers

Missing behavior following the "Customers" page migration.
In 1.7.5.2. when clicking on a row, it opens the customer's view page.
In 17.6.1 it doesn't work anymore.

Workaround:
It is still possible to access the customer's view via the actions dropdown on the right side of the rows. But it takes 2 clicks instead of one #productivity.

To Reproduce

  1. Go to Customers > Customers
  2. Click on a customer row
  3. See error -> Nothing happens

Screenshots
https://drive.google.com/file/d/1CTavM3hvYwZCDtWWHiWqamU14kvJVkUL/view?usp=sharing

[UPDATED OCT 8 19]
Specs for all grids
https://github.com/PrestaShop/prestashop-specs/pull/71/files

Additional information
PrestaShop version: 1.7.6.1

@samuel-pires samuel-pires changed the title Direct access to customer's page missing from Customers list Direct access to customer's view missing from Customers list row Oct 4, 2019
@samuel-pires samuel-pires removed the Regression label Oct 4, 2019
@khouloudbelguith khouloudbelguith added the BO label Oct 4, 2019
@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Oct 4, 2019

Hi @samuel-pires,

Same issue with PS1.7.6.1.
I think it is a regression, we should add the regression label, what do you think?

Thanks!

@samuel-pires

This comment has been minimized.

Copy link
Author

@samuel-pires samuel-pires commented Oct 4, 2019

Apparently this behavior is missing from many tables in migrated pages (not enough detailed specs).

@matks do you want us to regroup all the impacted tables and create an EPIC?

@PrestaShop/prestashop-core-developers do we consider this issue as a regression? To me it is., and it should be fixed before releasing a new version.

@PierreRambaud

This comment has been minimized.

Copy link
Contributor

@PierreRambaud PierreRambaud commented Oct 4, 2019

@samuel-pires at least for me, it's regression and must be fixed!

@samuel-pires

This comment has been minimized.

Copy link
Author

@samuel-pires samuel-pires commented Oct 4, 2019

@samuel-pires at least for me, it's regression and must be fixed!

Alright, I'll identify all impacted tables and define the missing behavior in the specs. So we can fix it.
Will add the issues in the 1.7.6 project.

@samuel-pires samuel-pires added this to Backlog in PrestaShop 1.7.6 via automation Oct 4, 2019
@colinegin colinegin moved this from Backlog to To do in PrestaShop 1.7.6 Oct 7, 2019
@jolelievre jolelievre self-assigned this Oct 7, 2019
@jolelievre jolelievre moved this from To do to In progress in PrestaShop 1.7.6 Oct 7, 2019
@jolelievre jolelievre moved this from In progress to To be reviewed in PrestaShop 1.7.6 Oct 7, 2019
@samuel-pires

This comment has been minimized.

Copy link
Author

@samuel-pires samuel-pires commented Oct 7, 2019

Hi @TristanLDD & @jolelievre,
I checked the pre-migration behaviors on the grids identified by Jo.
Here are the details.

How to read:
Defaut button -> the action displayed in the button on the right side of the row.
Options -> actions available in the dropdown (or the 3 dots) in the right side of the row.
Row -> action available by clicking on the row, as it was before migration.

Here are the specs : https://github.com/PrestaShop/prestashop-specs/pull/71/files

cheers

@jolelievre jolelievre moved this from To be reviewed to In progress in PrestaShop 1.7.6 Oct 8, 2019
@jolelievre jolelievre moved this from In progress to To be tested in PrestaShop 1.7.6 Oct 8, 2019
@jolelievre jolelievre moved this from To be tested to To be reviewed in PrestaShop 1.7.6 Oct 8, 2019
@matks matks removed the To Do label Oct 10, 2019
@matks matks removed the waiting for dev label Oct 10, 2019
@matks matks moved this from To be reviewed to To be tested in PrestaShop 1.7.6 Oct 10, 2019
@sarahdib sarahdib moved this from To be tested to To be merged in PrestaShop 1.7.6 Oct 11, 2019
@sarahdib sarahdib added this to the 1.7.6.2 milestone Oct 11, 2019
@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Oct 11, 2019

Fixed by #15859

@matks matks closed this Oct 11, 2019
PrestaShop 1.7.6 automation moved this from To be merged to Done Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.