Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle search in reduction column for "Catalog > Discounts > Catalog price rules > Add new / edit catalog price rule" page #15890

Closed
matks opened this issue Oct 9, 2019 · 3 comments · Fixed by #18691
Assignees
Labels
Fixed Resolution: issue closed because fixed migration symfony migration project
Milestone

Comments

@matks
Copy link
Contributor

matks commented Oct 9, 2019

We have migrated page "Catalog > Discounts > Catalog price rules > Add new / edit catalog price rule" in PR #13584

However we have found one issue: #13584 (comment)

Basically, what happens is:

  1. I create a catalog price rule with a reduction of 10.00005
  2. I go to listing: well, on the listing the reduction is displayed but rounded so I see it was 10.00

Capture d’écran 2019-10-09 à 18 27 36

  1. However ... the "reduction" input I can use to "search for catalog price rules" is looking for an exact match.
    => So if I search all catalog rules whose reduction is 10.00005, I find my catalog price rule
    => So if I search all catalog rules whose reduction is 10.0, I cannot find my catalog price rule

There's a weird behavior here, which is that:

  • the "search" input looks for exact matches
  • but the data is being displayed after a rounding, so the customer cannot see the exact match 😄

@MatShir @marionf

@matks matks added the migration symfony migration project label Oct 9, 2019
@marionf marionf changed the title How to handle search in reduction column for "Catalog > Discounts > Cart rules > Add new / edit catalog price rule" page How to handle search in reduction column for "Catalog > Discounts > Catalog price rules > Add new / edit catalog price rule" page Oct 10, 2019
@marionf
Copy link
Contributor

marionf commented Oct 10, 2019

As the listing displays the amount rounded, If I search 10 or 10.00 it should find the result
Is it possible to do that ?

@MatShir
Copy link
Contributor

MatShir commented Jan 9, 2020

I get the impression that this is a problem on the whole list for searches for numbers on Legacy. On the order page, if I type 20 to search for an order with a value of 20.84, I would not find it.

But it seems after a migrated page such as Product Page works fine. The problem might be fixed after migration? Wdyt @matks @PrestaShop/Prestashop-core-developers

@MatShir MatShir added the Waiting for dev Status: action required, waiting for tech feedback label Jan 9, 2020
@matks
Copy link
Contributor Author

matks commented Apr 17, 2020

I get the impression that this is a problem on the whole list for searches for numbers on Legacy. On the order page, if I type 20 to search for an order with a value of 20.84, I would not find it.

But it seems after a migrated page such as Product Page works fine. The problem might be fixed after migration? Wdyt @matks @PrestaShop/prestashop-core-developers

Product Listing page has been migrated differently than other listing pages (and will need re-migration to be harmonized)

I think what @marionf said must be tried.
"As the listing displays the amount rounded, If I search 10 or 10.00 it should find the result"

@Progi1984 Progi1984 added this to Backlog in PrestaShop 1.7.8.0 via automation Apr 27, 2020
@Progi1984 Progi1984 added this to the 1.7.8.0 milestone Apr 27, 2020
@Progi1984 Progi1984 moved this from Backlog to To be tested in PrestaShop 1.7.8.0 Apr 27, 2020
@SD1982 SD1982 moved this from To be tested to To be merged in PrestaShop 1.7.8.0 Jun 17, 2020
@matks matks moved this from To be merged to Done in PrestaShop 1.7.8.0 Jun 17, 2020
@prestashop-issue-bot prestashop-issue-bot bot added the Fixed Resolution: issue closed because fixed label Jun 17, 2020
@matks matks added Fixed Resolution: issue closed because fixed and removed Fixed Resolution: issue closed because fixed Waiting for dev Status: action required, waiting for tech feedback labels Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Resolution: issue closed because fixed migration symfony migration project
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants