Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BO - can't enable/disable Newsletter option & Enabled option when the field "Partner offers" is required #16509

Closed
khouloudbelguith opened this issue Nov 22, 2019 · 3 comments

Comments

@khouloudbelguith
Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Nov 22, 2019

Describe the bug
In the BO => Customers page => we can't enable/disable Newsletter option & Enabled option when the field "Partner offers" is required
image

To Reproduce
Steps to reproduce the behavior:

  1. Go to BO => Customers => Click on Set required fields for this section
  2. Check the "Partner offers" option
  3. Save
  4. Create a new customer from BO with enabling Partner offers => the customer is successfully saved
  5. In the Customers list page, try to disable this customer or try to enable the Newsletter option
  6. see the error

It is ok with ps1.7.5.2.
https://drive.google.com/file/d/1huf8kkW0-q8lr-JXR1mJOqt0VPNXHAMp/view
Screenshots
https://drive.google.com/file/d/1mXJIaUM45ce8y4ugDsdrXPuu_upecjEc/view

Additional information
PrestaShop version: 1.7.6.1, 1.7.6.2build1, develop
PHP version: 7.1

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor Author

@khouloudbelguith khouloudbelguith commented Nov 26, 2019

@matthieu-rolland matthieu-rolland moved this from Backlog to In progress in PrestaShop 1.7.6 Nov 28, 2019
@matthieu-rolland matthieu-rolland self-assigned this Nov 28, 2019
@matthieu-rolland matthieu-rolland moved this from In progress to To be reviewed in PrestaShop 1.7.6 Dec 2, 2019
@colinegin colinegin moved this from To be reviewed to To be tested in PrestaShop 1.7.6 Dec 4, 2019
@colinegin

This comment has been minimized.

Copy link

@colinegin colinegin commented Dec 4, 2019

After discuting with @Robin-Fischer-PS we have decided to rollback the new behaviour that has been introduced in 1760 (PR #13887) to enable merchants to disable partners offers in the BO even though this is a required field.

@Robin-Fischer-PS Robin-Fischer-PS moved this from To be tested to To be merged in PrestaShop 1.7.6 Dec 4, 2019
@Robin-Fischer-PS Robin-Fischer-PS added Fixed and removed To Do labels Dec 4, 2019
@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.6.3 milestone Dec 4, 2019
@Progi1984

This comment has been minimized.

Copy link
Contributor

@Progi1984 Progi1984 commented Dec 19, 2019

Merged in #16648

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.