Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error - Unclear alert when adding a profile's name more than 32 chars #16725

Closed
khouloudbelguith opened this issue Dec 6, 2019 · 4 comments
Closed

Comments

@khouloudbelguith
Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Dec 6, 2019

Describe the bug
Unclear alert when adding a profile's name more than 32 chars

To Reproduce
Steps to reproduce the behavior:

  1. Go to BO => Advanced Parameters => Team => Profiles
  2. Create a profile with a name more than 32 chars
  3. Save
  4. See error

With PS1.7.5.2, it was very clear
image

Screenshots
image

Additional information
PrestaShop version: 1.7.6.2, 1.7.6.0
PHP version: 7.1

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor Author

@khouloudbelguith khouloudbelguith commented Dec 6, 2019

This is a critical issue because it breaks the automatic test.
Related to #16514

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor Author

@khouloudbelguith khouloudbelguith commented Dec 6, 2019

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor Author

@khouloudbelguith khouloudbelguith commented Dec 9, 2019

Nightly is fixed with this PR: #16727

@colinegin colinegin moved this from Backlog to To do in PrestaShop 1.7.6 Dec 18, 2019
@atomiix atomiix moved this from To do to To be reviewed in PrestaShop 1.7.6 Dec 23, 2019
@atomiix atomiix self-assigned this Dec 23, 2019
@jolelievre jolelievre moved this from To be reviewed to To be tested in PrestaShop 1.7.6 Jan 9, 2020
@Robin-Fischer-PS Robin-Fischer-PS moved this from To be tested to To be merged in PrestaShop 1.7.6 Jan 13, 2020
@Robin-Fischer-PS Robin-Fischer-PS added Fixed and removed To Do labels Jan 13, 2020
@Robin-Fischer-PS Robin-Fischer-PS added this to the 1.7.6.3 milestone Jan 13, 2020
@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Jan 13, 2020

Fixed by #16906

@matks matks closed this Jan 13, 2020
PrestaShop 1.7.6 automation moved this from To be merged to Done Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.