Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in mails/it/order_customer_comment.html #16829

Closed
maofree opened this issue Dec 16, 2019 · 4 comments
Closed

Error in mails/it/order_customer_comment.html #16829

maofree opened this issue Dec 16, 2019 · 4 comments

Comments

@maofree
Copy link

@maofree maofree commented Dec 16, 2019

Hi
I found an error in the file
mails/it/order_customer_comment.html
it is written firstrname instead of firstname
it is necessary to remove the "r" after first

the english version is ok
bye

Screenshots
2

Additional information
PrestaShop version: 1.7.6.2
PHP version: 7.2

@mariem-abid

This comment has been minimized.

Copy link

@mariem-abid mariem-abid commented Dec 16, 2019

Hi @maofree,

Thank you for your report.
We'll first try to reproduce it and we'll come back to you if we need more information.

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Dec 17, 2019

Hi @maofree, thanks for your report.

I manage to reproduce the issue with PS1.7.6.1 & PS1.7.6.2.
In fact, this issue was fixed by this PR: #14945
It is merged, but this modification was removed again by this PR: https://github.com/PrestaShop/PrestaShop/pull/14719/files#diff-ad069b98e9b581f219f28732198910d1L253
So, it is a regression
image

I’ll add this to the debug roadmap so that it’s fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!
Thanks!

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Dec 17, 2019

@jolelievre jolelievre self-assigned this Dec 17, 2019
@marionf marionf added this to Backlog in PrestaShop 1.7.6 via automation Dec 17, 2019
@colinegin colinegin moved this from Backlog to To do in PrestaShop 1.7.6 Dec 18, 2019
@jolelievre jolelievre moved this from To do to In progress in PrestaShop 1.7.6 Dec 20, 2019
@jolelievre jolelievre moved this from In progress to To be reviewed in PrestaShop 1.7.6 Dec 20, 2019
@eternoendless eternoendless moved this from To be reviewed to To be tested in PrestaShop 1.7.6 Dec 23, 2019
@matks

This comment has been minimized.

Copy link
Contributor

@matks matks commented Dec 26, 2019

Fixed by #16888

@matks matks closed this Dec 26, 2019
PrestaShop 1.7.6 automation moved this from To be tested to Done Dec 26, 2019
@marionf marionf added Fixed and removed To Do labels Dec 26, 2019
@marionf marionf added this to the 1.7.6.3 milestone Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.