Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cart rule restrictons wrong saved #17603

Open
Flower7C3 opened this issue Feb 11, 2020 · 7 comments
Open

Cart rule restrictons wrong saved #17603

Flower7C3 opened this issue Feb 11, 2020 · 7 comments

Comments

@Flower7C3
Copy link

@Flower7C3 Flower7C3 commented Feb 11, 2020

Describe the bug
Unable to save selected cart rule restrictions.

To Reproduce
Steps to reproduce the behavior:
PS: You should have more than 40 cart rules to reproduce the issue

  1. Go to BO, Catalogue, Cart Rules
  2. Add new rule
  3. Check restrictions and move 1 restriction to left
  4. Save
  5. Edit this rule
  6. Multiple restrictions on left

Screenshots
Remove 1 restriction
image

I have saved 190 restrictions in DB
image

So my rule should has 188 restrictions saved in database, but has only 39
image

And visible in BO
image

Problem is probably in select, which is loading asynchronously elements when I scroll to the bottom
image

Additional information
PrestaShop version: 1.7.6.2
PHP version: 7.2

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Feb 11, 2020

Hi @Flower7C3,

I did not manage to reproduce the issue with PS1.7.6.3.
I attached a screen record
https://drive.google.com/file/d/1G8zmvyy0hsvrpbROSCf20PcdMmyim0Ne/view
Thanks to check & feedback.

@Flower7C3

This comment has been minimized.

Copy link
Author

@Flower7C3 Flower7C3 commented Feb 11, 2020

I am using PS 1.7.6.2. During the weekend I am planning to update to 1.7.6.3 so maybe the problem will disappear or it is caused by some module.

I will back later with info.

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Feb 11, 2020

@Flower7C3, thanks!
Waiting for your feedback.

@Flower7C3

This comment has been minimized.

Copy link
Author

@Flower7C3 Flower7C3 commented Feb 15, 2020

Hi @khouloudbelguith, after upgrading to PS 1.7.6.3 problem still exists on my instance.

Could You do recheck, but with more cart rules? I think that problem is when there are more than 40 cart rules in database. So not all items are in right select during page load. And they are being loaded when You scroll down on the list (http://s000.tinyupload.com/index.php?file_id=32136249853765246079).

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Feb 17, 2020

@Flower7C3,

I think that problem is when there are more than 40 cart rules in database

No, I tried with PS1.7.6.3 & I have 41 cart rules & it is OK.
I attached a screen record
cart_rule.webm.zip
We need to retrieve the PHP error log and the debug mode report in order to find out what's wrong.
Don't you know how to get this information? Please read the following article:
http://build.prestashop.com/howtos/misc/how-to-create-bug-report/

Thanks!

@Flower7C3

This comment has been minimized.

Copy link
Author

@Flower7C3 Flower7C3 commented Feb 17, 2020

But when You scroll down to test cart rule it probably cause AJAX request for more rules. Please do not scroll down.

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

@khouloudbelguith khouloudbelguith commented Feb 17, 2020

@Flower7C3, thanks for your feedback.
I manage to reproduce the issue with PS1.7.6.3 & PS1.7.5.2
If you have more than 40 cart rules, All the cart rules > 40 will be displayed in the Uncombinable cart rules.
https://drive.google.com/file/d/1vpvNtWJzmTPIgVEZmaHWGX8zxXCEQt2X/view
I’ll add this to the debug roadmap so that it’s fixed. If you have already fixed it on your end or if you think you can do it, please do send us a pull request!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.