Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox - horizontal scrollbar on homepage under 991px #25459

Closed
Hlavtox opened this issue Jul 29, 2021 · 5 comments · Fixed by #25569
Closed

Firefox - horizontal scrollbar on homepage under 991px #25459

Hlavtox opened this issue Jul 29, 2021 · 5 comments · Fixed by #25569
Assignees
Labels
1.7.7.x Branch 1.7.7.5 Affects versions 1.7.8.x Branch Bug Type: Bug Fixed Resolution: issue closed because fixed FO Category: Front Office Front-end Category: Front end PR available Solution: issue is being addressed Regression Type: regression Responsive Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification
Milestone

Comments

@Hlavtox
Copy link
Contributor

Hlavtox commented Jul 29, 2021

Describe the bug

There is a horizontal scrollbar on homepage of 1.7.8 beta under 991px. Caused by styling of the carusel, which overflows the content.

Not an uncommon issue, it must be done in a different way - https://www.google.com/search?q=100vw+overflow

Does anybody even check it when coding it? This must be immediately reproduced on first opening of inspector. 🤔

Expected behavior

There should be no scrollbar.

Screenshots

responsive

Additional information

  • PrestaShop version: 1.7.8 beta
  • PHP version: 7.2
@hibatallahAouadni
Copy link
Contributor

Hello @Hlavtox

I didn't manage to reproduce the issue with PS178x, see the attached screenshot below:

image

Please check and feedback.
Thanks!

@hibatallahAouadni hibatallahAouadni added 1.7.8.x Branch Bug Type: Bug FO Category: Front Office Front-end Category: Front end NMI Status: issue needs more information Responsive labels Jul 29, 2021
@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jul 29, 2021

@hibatallahAouadni Reproduced on latest Firefox
firefox

@Hlavtox
Copy link
Contributor Author

Hlavtox commented Jul 29, 2021

@khouloudbelguith
Copy link
Contributor

Hi @Hlavtox,

Thanks for these clarifications.
I manage to reproduce the issue with branch 1.7.8.x, PS1775 and the branch 1.7.7.x using Firefox v90 and V78.5.0esr (64 bits)
image

It is ok with PS1769 => regression from PS177.
image

I tried with Chrome v92 => ok

I will add to the bug roadmap.
Please be aware that due to the high number of reported issues, some bugs might take a very long time to be resolved. If this issue is important to you and you cannot wait for it to be fixed on the project's own time, we strongly suggest you consider hiring a specialist to help you.
If you manage to get the problem fixed, then please contribute the fix back to the project as a Pull Request. Remember that the more people contribute, the better PrestaShop becomes for everyone.

Thanks!

@khouloudbelguith khouloudbelguith changed the title 1.7.8 - horizontal scrollbar on homepage under 991px Firefox - horizontal scrollbar on homepage under 991px Jul 30, 2021
@khouloudbelguith khouloudbelguith added 1.7.7.5 Affects versions 1.7.7.x Branch Regression Type: regression Ready Status: Issue is ready to be worked on Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification and removed NMI Status: issue needs more information labels Jul 30, 2021
@khouloudbelguith khouloudbelguith added this to Backlog in PrestaShop 1.7.7.7 via automation Jul 30, 2021
@marionf marionf added this to To do in Nice To Have via automation Aug 2, 2021
@marionf marionf removed this from Backlog in PrestaShop 1.7.7.7 Aug 2, 2021
@prestonBot prestonBot added the PR available Solution: issue is being addressed label Aug 11, 2021
@hibatallahAouadni hibatallahAouadni added Fixed Resolution: issue closed because fixed and removed Ready Status: Issue is ready to be worked on labels Aug 20, 2021
@hibatallahAouadni hibatallahAouadni moved this from To do to To be merged in Nice To Have Aug 20, 2021
@NeOMakinG NeOMakinG linked a pull request Aug 20, 2021 that will close this issue
@Progi1984 Progi1984 added this to the 1.7.8.1 milestone Aug 23, 2021
@Progi1984 Progi1984 removed this from To be merged in Nice To Have Aug 23, 2021
@Progi1984 Progi1984 added this to Not ready in PrestaShop 1.7.8.1 via automation Aug 23, 2021
@Progi1984 Progi1984 moved this from Not ready to Done in PrestaShop 1.7.8.1 Aug 23, 2021
@Progi1984
Copy link
Contributor

Fixed by @NeOMakinG in #25569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.7.7.x Branch 1.7.7.5 Affects versions 1.7.8.x Branch Bug Type: Bug Fixed Resolution: issue closed because fixed FO Category: Front Office Front-end Category: Front end PR available Solution: issue is being addressed Regression Type: regression Responsive Trivial Severity: trivial bug > https://build.prestashop.com/news/severity-classification
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants