Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOM-5355] minimum order in the second currency does not work #9665

Closed
prestonBot opened this issue Aug 22, 2018 · 10 comments

Comments

@prestonBot
Copy link
Collaborator

commented Aug 22, 2018

This issue has been migrated from the Forge. Read the original ticket here.

  • Reporter: Katrich
  • Created at: Tue, 17 Apr 2018 16:29:27 +0200

Good afternoon. Faced the problem that when ordering in a currency different from the main one (for example, the basic dollar and the second hryvnia) with the minimum order of $ 15, the basket misses orders in the second currency for less than 15 dollars (in UAH it is 480 hryvnia) and in the basket shows the wrong amount of the minimum order. Here is the message "For the order to be accepted, its minimum amount should be 10 613.40 UAH. Now the amount of your order is 0.00 UAH"

  • How to reproduce the issue ?

Create an order for 500 hryvnia, which is 18 dollars, and we have a minimum order placed in the admin panel at 15 dollars


-Steps to reproduce :
1-Install PS 1.7.3.1. with English language / France country
2-Set "Default currency" to US Dollar
3-Import the Ukraine package
4-Set "Minimum purchase total required in order to validate the order" to 15$
*First issue:
In FO add to the cart a product with "10.80 $"
-try with Currency "USD $" => an alert is displayed "A minimum shopping cart total of $15.00 " => OK
-try with Currency "UAH ₴" => the alert disappear
*Second issue
In FO add to the cart a product with "0.01$"
-Navigate to the cart page, change to Currency "UAH ₴" => Total (tax incl.)UAH0.26 => an alert is displayed "A minimum shopping cart total of UAH10,186.86 (tax excl.) is required to validate your order. Current cart total is UAH6.78 (tax excl.).. => UAH6.78 not correct.
@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: khouloud.belguith
  • Created at: Tue, 17 Apr 2018 17:12:02 +0200

Hi Evgen,

Could you please confirm these steps to reproduce your issue?
Steps to reproduce this issue :
Install PS 1.7.3.1. with English language / France country
Set "Default currency" to US Dollar
Import the Ukraine package
Set "Minimum purchase total required in order to validate the order" to 15$
In FO add to the cart a product with "10.80 $"
try with Currency "USD $" => an alert is displayed "A minimum shopping cart total of $15.00 " => OK
try with Currency "UAH ₴" => the alert disappear

Best regards, Khouloud

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: katrich
  • Created at: Tue, 17 Apr 2018 19:18:03 +0200

Yes that's right. if you establish Ukrainian localization with hryvnia, this notice will remain, but the amount of the minimum order will be much greater than the real one. And the basket will miss orders even for the equivalent of $ 0.01.

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: khouloud.belguith
  • Created at: Wed, 18 Apr 2018 13:57:23 +0200

Hi Evgen,

  • Steps to reproduce :
    Install PS 1.7.3.1. with English language / France country
    Set "Default currency" to US Dollar
    Import the Ukraine package
    Set "Minimum purchase total required in order to validate the order" to 15$
  1. First issue:
    In FO add to the cart a product with "10.80 $"
    try with Currency "USD $" => an alert is displayed "A minimum shopping cart total of $15.00 " => OK
    try with Currency "UAH ₴" => the alert disappear
  2. Second issue
    In FO add to the cart a product with "0.01$"
    Navigate to the cart page, change to Currency "UAH ₴" => Total (tax incl.)UAH0.26 => an alert is displayed "A minimum shopping cart total of UAH10,186.86 (tax excl.) is required to validate your order. Current cart total is UAH6.78 (tax excl.).. => UAH6.78 not correct.

We will see how to fix it.

Best regards, Khouloud

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: thesebah
  • Created at: Mon, 16 Jul 2018 14:56:40 +0200

Heya,

It's been a couple of months already, any updates on this issue?
Also, I don't think that this should be with a 'minor' priority as it affects everyone with multicurrency shops.

Thanks,
Seb

@prestonBot

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: khouloud.belguith
  • Created at: Mon, 16 Jul 2018 15:00:54 +0200

Hi,

There are some major issues to solve before this one.
So, it will probably not solved right now.
But PrestaShop is an open source project, so it can be solved before if someone submits a pull request to solve it.

Best regards, Khouloud

@prestonBot prestonBot referenced this issue Aug 23, 2018
4 of 34 tasks complete

sadlyblue added a commit to sadlyblue/PrestaShop that referenced this issue Sep 5, 2018

Fix minimum order amount for secondary currency
Fix for PrestaShop#9665 [BOOM-5355]
Switched from convertAmount to format amount for $productsTotalExcludingTax (cart already returns value in correct currency), and $minimalPurchase only needs to be converted to current currency once.

@colinegin colinegin added this to To do in PrestaShop 1.7.6 via automation Oct 26, 2018

@colinegin colinegin added this to the 1.7.6.0 milestone Oct 26, 2018

@colinegin colinegin moved this from To do to To be reviewed in PrestaShop 1.7.6 Oct 26, 2018

@marionf marionf removed the To Do label Oct 26, 2018

@Comanche-aLike

This comment has been minimized.

Copy link

commented Oct 31, 2018

I have the same problem.

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Oct 31, 2018

Hi @Comanche-aLike,

Here's the PR: #10294 to solve the issue.
Thanks!

@Comanche-aLike

This comment has been minimized.

Copy link

commented Nov 28, 2018

Hi @khouloudbelguith

thank you for your reply. I will try to solve it reffering to #10294, but I wonder will this work with 1.7.2.5 prestashop version?

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

commented Nov 28, 2018

@Comanche-aLike, This PR #10294 is still open, not tested yet & not merged yet.
But, there are small fixes, changes are made only in one file, so you can apply this patch in the version 1.7.2.5 & check if this fix works.
Thanks!

@Comanche-aLike

This comment has been minimized.

Copy link

commented Nov 28, 2018

@khouloudbelguith I did the changes and, as for now, it works perfectly. Thank your help. Have a good day!

Best regards
Comanche-aLike

@eternoendless eternoendless moved this from To be reviewed to To be tested in PrestaShop 1.7.6 Jan 2, 2019

@marionf marionf moved this from To be tested to to be merged in PrestaShop 1.7.6 Jan 2, 2019

@marionf marionf added the Fixed label Jan 2, 2019

PrestaShop 1.7.6 automation moved this from to be merged to Done Jan 3, 2019

@prestonBot prestonBot referenced this issue Feb 27, 2019
20 of 56 tasks complete
@colinegin colinegin referenced this issue Aug 2, 2019
21 of 39 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.