New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOM-5139] Unable to translate some strings in bank wire payment module #9697

Closed
prestonBot opened this Issue Aug 22, 2018 · 21 comments

Comments

@prestonBot
Copy link
Collaborator

prestonBot commented Aug 22, 2018

This issue has been migrated from the Forge. Read the original ticket here.

  • Reporter: krasny
  • Created at: Tue, 20 Mar 2018 15:37:10 +0100

There seems to be issue with translation of some strings from ps_wirepayment module. While some strings are available in module translations in the back office,some are not.

Following strings are unavailable for translation:
 
   


      {l s='Please specify your order reference %s in the bankwire description.' sprintf=[$reference] d='Modules.Wirepayment.Shop'}

      {l s='We\'ve also sent you this information by e-mail.' d='Modules.Wirepayment.Shop'}
   


    {l s='Your order will be sent as soon as we receive payment.' d='Modules.Wirepayment.Shop'}
   


      {l s='If you have questions, comments or concerns, please contact our [1]expert customer support team[/1].' d='Modules.Wirepayment.Shop' sprintf=['[1]' => "", '[/1]' => '']}
   


 
they are used in /modules/ps_wirepayment/views/templates/hook/payment_return.tpl

  • How to reproduce the issue ?

N/A

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: khouloud.belguith
  • Created at: Wed, 21 Mar 2018 11:13:32 +0100

Hi Jan,
Thanks to navigate to your BO => International => Translations and try to MODIFY TRANSLATIONS

  1. Type of translation => Installed modules translations
  2. Select your module => Bank transfer
  3. Select your language desired.
  4. Click on Modify button and try to complete all missings expressions

Thanks to check and feedback.

Best regards, Khouloud

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: krasny
  • Created at: Wed, 21 Mar 2018 11:27:48 +0100

Hello,

well strings in questions are not available for translation. I even tried clean install on my testing server with same results. Other strings from bank wire module are available for translation just those from payment_return.tpl are unavailable. File permissions are fine. I noticed multiple users reporting this issue on the forum so it is not just my problem.

Jan

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: krasny
  • Created at: Wed, 21 Mar 2018 11:35:21 +0100

Click on Modify button and try to complete all missings expressions - I forget to note that all expressions are translated.

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: khouloud.belguith
  • Created at: Thu, 22 Mar 2018 11:54:50 +0100

Hi Jan,

Thanks for the clarifications.
I manage to reproduce the issue with the last version 1.7.3.0. and the Bank transfer module v2.0.3.

We will see how to fix it.

Best regards, Khouloud

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: eleazar
  • Created at: Sat, 7 Apr 2018 18:56:47 +0200

It's not so much a bug as carelessness.

Prestashop 1.7.3 was released with completely outdated translation variables in file /app/Resources/translations/default/ModulesWirepaymentShop.xlf and the corresponding file in the shop language.

Use the files from 1.7.2.2 to fix it.

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: thekingman
  • Created at: Fri, 13 Apr 2018 15:07:33 +0200

Can u explain in more detail how to use the files to fix it? (Prestashop newbie here - but i really need this solution). 

Regards, 

David

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: mr_absinthe
  • Created at: Tue, 17 Apr 2018 20:25:36 +0200

This can still be reproduced in v 1.7.3.1. Is there a way to fix it?

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: paolo
  • Created at: Thu, 19 Apr 2018 12:10:25 +0200

While waiting for a solution to be issued, I solved this in PS 1.7.3 by modifying manually translation files and then translating in other languages using Prestashop system.

File app\Resources\translations\default\ModulesWirepaymentShop.xfl, added at the end of the file, before the body closing tag:

{{ }}{{ }}
{{ Please specify your order reference %s in the bankwire description.}}
{{ Please specify your order reference %s in the bankwire description.}}
{{ Context:}}
File: modules/ps_wirepayment/views/templates/hook/payment_return.tpl:34
{{ }}
{{ }}
{{ We've also sent you this information by e-mail.}}
{{ We've also sent you this information by e-mail.}}
{{ Context:}}
File: modules/ps_wirepayment/views/templates/hook/payment_return.tpl:35
{{ }}
{{ }}
{{ Your order will be sent as soon as we receive payment.}}
{{ Your order will be sent as soon as we receive payment.}}
{{ Context:}}
File: modules/ps_wirepayment/views/templates/hook/payment_return.tpl:37
{{ }}
{{ }}
{{ If you have questions, comments or concerns, please contact our [1]expert customer support team[/1].}}
{{ If you have questions, comments or concerns, please contact our [1]expert customer support team[/1].}}
{{ Context:}}
File: modules/ps_wirepayment/views/templates/hook/payment_return.tpl:39
{{ }}

File app\Resources\translations\EN-us\ModulesWirepaymentShop.xfl, added at the end of the file, before the body closing tag (this may be redundant):

{{ }}
{{ Please specify your order reference %s in the bankwire description.}}
{{ Please specify your order reference %s in the bankwire description.}}
{{ Context:}}
File: modules/ps_wirepayment/views/templates/hook/payment_return.tpl:34
{{ }}
{{ }}
{{ We've also sent you this information by e-mail.}}
{{ We've also sent you this information by e-mail.}}
{{ Context:}}
File: modules/ps_wirepayment/views/templates/hook/payment_return.tpl:35
{{ }}
{{ }}
{{ Your order will be sent as soon as we receive payment.}}
{{ Your order will be sent as soon as we receive payment.}}
{{ Context:}}
File: modules/ps_wirepayment/views/templates/hook/payment_return.tpl:37
{{ }}
{{ }}
{{ If you have questions, comments or concerns, please contact our [1]expert customer support team[/1].}}
{{ If you have questions, comments or concerns, please contact our [1]expert customer support team[/1].}}
{{ Context:}}
File: modules/ps_wirepayment/views/templates/hook/payment_return.tpl:39
{{ }}

Then in Prestashop BO in International->Translations I selected the bank wire module, checked that the new strings existed in English, and then translated them into Italian and French.

This is working for me.

Regards.

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: thekingman
  • Created at: Thu, 19 Apr 2018 12:27:51 +0200

Thank you for your effort to help us. I will try that out and report how it works for me. 

Regards

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: rdy4ever
  • Created at: Wed, 11 Jul 2018 16:50:45 +0200

If you are using a custom or customized theme that you will not upgrade, you can copy the templete file in the theme directory like:

themes/your_theme/modules/ps_wirepayment/views/templates/hook/payment_return.tpl

And then change the domain for all strings, instead of {l s="My string" mod="ps_bankwire"} use something like {l s="My string" d="Shop.Bankwire"}

You will then be able to translate all strings as part of your theme (International -> Translations -> Theme)

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: podemski
  • Created at: Mon, 6 Aug 2018 16:04:29 +0200

Hello everyone,

it's important to notice that it's all because of {include} in above these strings

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: bianca
  • Created at: Wed, 8 Aug 2018 11:35:06 +0200

Thanks a lot, works for me as well!

@fdelprete

This comment has been minimized.

Copy link

fdelprete commented Sep 18, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: podemski
  • Created at: Mon, 6 Aug 2018 16:04:29 +0200

Hello everyone,

it's important to notice that it's all because of {include} in above these strings

Yes, I can confirm that also in modules/ps_emailalerts/views/templates/front/mailalerts-account.tpl the cause of the missing string is the {include} directive above.

@dmstech1

This comment has been minimized.

Copy link

dmstech1 commented Sep 22, 2018

I have the same problem. And the fix posted. I can't get it to work :(

Is there any news about a fix?

@khouloudbelguith

This comment has been minimized.

Copy link
Contributor

khouloudbelguith commented Sep 24, 2018

Hi @dmstech1,

Sorry not yet.
This issue is added to our bug roadmap.
But PrestaShop is an open source project, so it can be solved before if someone submits a pull request to solve it.

Best regards, Khouloud

@kpodemski

This comment has been minimized.

Copy link
Contributor

kpodemski commented Oct 14, 2018

Still an issue in 1.7.5, it's a critical one, i think that this should have higher priority

@web-plus

This comment has been minimized.

Copy link
Contributor

web-plus commented Oct 15, 2018

Still an issue in 1.7.5, it's a critical one, i think that this should have higher priority

Yes, I agree, people will not use 1.7 version if they have to fix translations manually. This is basic feature that should work.

@eternoendless eternoendless self-assigned this Oct 22, 2018

@colinegin colinegin added this to To do in PrestaShop 1.7.5 via automation Oct 26, 2018

@colinegin colinegin moved this from To do to To be tested in PrestaShop 1.7.5 Oct 26, 2018

@colinegin colinegin moved this from To be tested to In progress in PrestaShop 1.7.5 Oct 26, 2018

@eternoendless eternoendless added this to the 1.7.5.0 milestone Nov 9, 2018

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Nov 9, 2018

Fixed by #11345

Wordings weren't translatable because they were missing from the catalog due to a bug in our catalog extractor.

@eternoendless eternoendless moved this from In progress to To be reviewed in PrestaShop 1.7.5 Nov 9, 2018

@marionf marionf moved this from To be reviewed to To be tested in PrestaShop 1.7.5 Nov 12, 2018

@marionf marionf moved this from To be tested to To be merged in PrestaShop 1.7.5 Nov 12, 2018

@marionf marionf moved this from To be merged to Done in PrestaShop 1.7.5 Nov 13, 2018

@marionf marionf added Fixed and removed To Do labels Nov 13, 2018

@marionf marionf closed this Nov 13, 2018

@kpodemski

This comment has been minimized.

Copy link
Contributor

kpodemski commented Nov 13, 2018

@eternoendless you sure? have you tried to add new string to translate to this included file?

@diseniarte

This comment has been minimized.

Copy link

diseniarte commented Nov 17, 2018

Hope soon can be fixed, i try the code above and didn't work for me

@eternoendless

This comment has been minimized.

Copy link
Member

eternoendless commented Nov 30, 2018

@kpodemski They should be translatable once you update your default catalogue, as shown in the screenshot on the PR.

I tested it just now and it works:

screenshot 2018-11-30 at 17 28 04

screenshot 2018-11-30 at 17 30 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment