[BOOM-4298] Large number of product combinations block browser

[prestonBot]

This issue has been migrated from the Forge. Read the original ticket here.

• Reporter: laurentsupport
• Created at: Tue, 14 Nov 2017 11:35:21 +0100

Hello,

we have a client site conntected with icecat database.
At now it haves 4 active shops and abut 60000 articles. From icecat we have about 7500 features.
When client connect to backoffice and operate on product the browser blocks because the Features tab are too large.
Is there a best way to paginate and manage features in admin product page?

Kind regards,

• How to reproduce the issue ?

N/A

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: salma.moakhar
• Created at: Tue, 14 Nov 2017 14:42:34 +0100

Hi Laurent Ndaw,

We tried to work on the pagination declensions but it's not over yet.
We will also work to lighten the product page, it will take time, so unfortunately we have no solution currently.
I close the ticket, feel free to open a new ticket when needed.

Thanks & best regards, Salma

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: lila75
• Created at: Fri, 26 Jan 2018 17:46:02 +0100

I have the same problem, and you can't do anything for us ?

So i have to close my prestashop account and go to see magenta or another one ?

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: khouloud.belguith
• Created at: Fri, 26 Jan 2018 17:55:31 +0100

Hi,

We are aware about this issue and we are working on it.
No, this issue is in progress, it is assigned to our developer Jocelyn Fournier, he is working on it.
Thanks for your patience

Best regards, Khouloud

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: lila75
• Created at: Fri, 26 Jan 2018 18:02:02 +0100

is it possible to contact her ?

i'm in late with my work...

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: khouloud.belguith
• Created at: Fri, 26 Jan 2018 18:07:09 +0100

Hi ,

You can find his address mail Jocelyn Fournier in his profile

Best regards, Khouloud

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: lila75
• Created at: Fri, 26 Jan 2018 18:11:10 +0100

I don't know where is her profile.

Can you send me her address mail please?

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: lila75
• Created at: Fri, 26 Jan 2018 18:12:58 +0100

sorry, i find it.

 

Thank your for your reactivity...

best regards,

Lila

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: yoan - consult'in web
• Created at: Tue, 27 Feb 2018 10:46:00 +0100

Hello,

 

I have the same problem withmy customer, is it possible tu have a return about this resolving?

 

Thanks Yoan

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: joce
• Created at: Tue, 27 Feb 2018 14:02:43 +0100

boom-2950 needs to be fixed first

[prestonBot]

This comment has been migrated from the Forge. Read the original comment here.

• Author: root
• Created at: Wed, 18 Apr 2018 07:36:18 +0200

boom-2950 needs to be fixed first

Ok mr.Fournier,
now you fixed attribute saving problem in BOOM-2950
It is time to fix this one 4298 and take a look on similar behavior I reported at http://forge.prestashop.com/browse/BOOM-5350

I remember similar error on 1.6.* with endless spinning save button
without possibility to have scaleable [server side strength related] number of categories and products
Prestashop will lose it's competitiveness with other platforms.

[monsieurpitt]

Hello, do you have any update on this issue? It's starting to be a very important...

[mchbani]

Hi
I have the same issue with 1.7.4.4. any update please?

[khouloudbelguith]

Hi all,

This issue is in progress, it is assigned to our developer.
Thanks for your patience & your understanding!

[tengav]

When we fixed that, the problem seems to be longer.
Is there a workarround here?

[JanicW]

Hello, is there any news about this bug. I really need to add more than 390 combinations.

[matks]

Ping @jolelievre @MatShir this is EXACTLY what we aim to fix with Experimental Product Page !

[lim3ra]

Do we have any progress on this? I am having 500 errors on product edit pages and it seems it is related. Presta 1.7.7.8

[maofree]

Hi
try to upgrade your site to 1.7.8.1. do it on a clone website to be sure all modules are compatible

[jolelievre]

The product page is currently under re-development It will be available in the next version (8.0) however it is partially available in 1.7.8 as an experimental feature. The page was not fully finished but it is accessible by enabling the feature in Advanced Parameters > Experimental Features you can then enable the experimental product page.

From here you can then access it via additional buttons, when you are on your product page a button to switch to the new page Edit on experimental page this will give you a preview of the coming new product page

You can also try and test it on the develop branch where the page has even more features.

[maofree]

Hi @jolelievre
can you show me the extra buttons when I set the new experimental option?
I cannot see them in the product page

[jolelievre]

Hi @maofree and @lim3ra

Here is a short video that shows how to:

• enable the experimental feature
• access the experimental page from the "legacy page"
• quick display of the combinations generation and filtering in the experimental page

https://watch.screencastify.com/v/XkmPfNZymH8ToENFQkJf

So the new page is more optimized for products with a big number of combinations. However, we didn't test this with thousands of feature values (FeatureValue and Attribute are not the same thing). It seems like this issue is talking about both topics so I'm not sure it answers your need exactly.

In combination we now have pagination and some filtering features so it should improve performance a lot (or at the very least avoid blocking the page).

For features we didn't change much, meaning the list of all Features is loaded for each page (but the FeatureValue are loaded asynchronously after selection of the feature). So if you have 35000 different feature values they won't be all loaded at once (only feature by feature). However, if you have 15000 different features they will all be loaded on page load.

It might need to be improved (by searching the Feature via an API instead of loading the whole list for example), but we need feedback from you to know if it is necessary or not so don't hesitate to test this experimental page and provide us feedback. If we have time we may be able to fix/improve it before the 8.0 is released, but without feedback, we can't know what is performant enough or not.

[maofree]

thanks @jolelievre
understood how to find it

I've found a bug on the new combination tab pushing on the pencil icon

#26675

bye

[lim3ra]

Prestashop 1.7.8.1
PHP 7.4.24

Using new, experimental product page, still I can see this issue:

`Error: Allowed memory size of 536870912 bytes exhausted (tried to allocate 20480 bytes)

in FeatureRepository.php line 100`

do we have any other ideas?

[jolelievre]

@lim3ra can you tell me how many features and feature values you have in your database please?

[lim3ra]

ps_feature_value and ps_feature_product have around 130k records each

[jolelievre]

Ok, so there is no magical solution for such a large list 😅

Currently, we don't display all the feature values, however we create a select box with the whole list of Features. What we could do is not prefill this select bow and instead perform a search while the user is typing, but the drawback of this solution is that you can no longer scroll the list of features...

Then once the feature is selected we populate the feature values selector, again here if you have too many values there is a possibility of this update failing as well for lack of memory. Then we could make the value selector a search input as well but here we get the same drawback that you can't scroll the select bow anymore.

It's a tough one, because although I know this kind of feature would be case for shops which have 10k or 100k values, but it might make the feature less usable for small shops as well 🤔

[lim3ra]

I think I found the issue

SELECT * FROM ps_feature_productWHEREid_feature = 0; returns 130k records
SELECT * FROM ps_feature_valueWHEREid_feature = 0; - same

just to compare

SELECT * FROM ps_feature_valueWHEREid_feature != 0; returns ~2k records

IDK if there is some kind of bug but I have a feature with ID 0 duplicated thousands of times. I am going to clean DB, remove all entries about the feature with ID 0 and we will see what will happen.

---

update: yup, it is fixed now. Thank you all for help, seems my problem was not really related to this topic after all 🙃

[jolelievre]

Ohh this is very weird indeed, id_feature == 0 should not be possible since it's supposed to be an unsigned primary key with auto-increment Maybe your Mysql database is not correct, maybe you should check its structure but this is how the feature table is created:

CREATE TABLE `PREFIX_feature` (
  `id_feature` int(10) unsigned NOT NULL auto_increment,
  `position` int(10) unsigned NOT NULL DEFAULT '0',
  PRIMARY KEY (`id_feature`)
) ENGINE=ENGINE_TYPE DEFAULT CHARSET=utf8mb4 COLLATION;

So id_feature should never be 0, let's say that for some reason one row was created with this ID it should be unique because of the primary key.

[eternoendless]

@hibatallahAouadni @jolelievre can we call this as fixed by the new product page in 8.1?

[hibatallahAouadni]

Hello @eternoendless

This issue is fixed with the new Product Page V2 in 8.1.0 and develop 🎉
As you can see in the attached screenshot below, 672 combinations has been generated in 5 secondes 👏

We can close this issue as Fixed 🎉 Great Job Dev team @johstrom 👏 🙌 🚀

Thanks!