New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOM-3671] Viewed products don't work on fresh installed PS1.7 #9916

Closed
prestonBot opened this Issue Aug 22, 2018 · 17 comments

Comments

@prestonBot
Copy link
Collaborator

prestonBot commented Aug 22, 2018

This issue has been migrated from the Forge. Read the original ticket here.

  • Reporter: fortuner
  • Created at: Sat, 19 Aug 2017 17:23:01 +0200

Prestashop 1.7.2.1 + Classic theme
The viewed product block does not show on product page. Also why is it hooked on product page and not hooked to left/right column? So customer should go on some product page to see the products viewed before? Definitely an issue.

  • How to reproduce the issue ?

Install Prestashop 1.7.2.1


Install ps_blockviewed


Go to product page and be convinced that is not working

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: marion_francois
  • Created at: Mon, 21 Aug 2017 16:12:01 +0200

Je reproduis sur 1.7.2.1

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: fortuner
  • Created at: Fri, 1 Sep 2017 16:06:14 +0200

Any comments or fixes?
Its a major functionality and user experience loss, in my opinion.

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: marion_francois
  • Created at: Mon, 2 Oct 2017 17:11:31 +0200

Hi Igor Alexeyev,

Thanks for your feedback, it's added to our debug roadmap.

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: kerm
  • Created at: Thu, 23 Nov 2017 13:42:08 +0100

1.7.2.4, same bug here, no viewed products on product page footer

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: fortuner
  • Created at: Tue, 28 Nov 2017 02:56:27 +0100

I wonder, if prestashop team has any developers? Or is it module sellers only?

Are you guys gonna fix this bug? Are you even scratching to?

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: kerm
  • Created at: Tue, 28 Nov 2017 10:39:28 +0100

Here is fix, replace code from original file on code from this file:

ps_viewedproduct.txt

 

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: marion_francois
  • Created at: Tue, 28 Nov 2017 11:02:56 +0100

Hi Igor Alexeyev,

As indicated, it's added to our debug roadmap.

Dmitriy Thanks for diving into this!

Would you be willing to make a pull request on GitHub with your code suggestion?
https://github.com/PrestaShop/PrestaShop/tree/develop

Thank you!

 

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: fortuner
  • Created at: Tue, 28 Nov 2017 11:13:41 +0100

Thank you, Dmitriy!

Seems you could even replace the whole prestashop developers team

 

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: kerm
  • Created at: Tue, 28 Nov 2017 11:54:38 +0100

On github modules folder is empty.

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: rdy4ever
  • Created at: Tue, 12 Dec 2017 09:03:44 +0100

With Dmitriy 's fix it works initially but then it stops working. It works again (just for the first produscts, then stops again) if I unhook the module and rehook it. I have PS 1.7.2.4.

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: marion_francois
  • Created at: Mon, 15 Jan 2018 12:01:20 +0100

Hi Dmitriy

The repo for 1.7 version is this one: https://github.com/PrestaShop/ps_viewedproduct

Regards

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: rdy4ever
  • Created at: Wed, 21 Mar 2018 14:18:51 +0100

Dmitriy, do you have a similar fix for the cross selling module?

Thanks!

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: marion_francois
  • Created at: Mon, 23 Jul 2018 15:41:42 +0200

Hello Igor Alexeyev

We can't reproduce the issue on 1.7.4.1 with crossselling

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: khouloud.belguith
  • Created at: Wed, 8 Aug 2018 15:30:25 +0200

Hi,

There's a solution proposed by Igor Alexeyev.
ps_viewedproduct (1).php

Best regards, Khouloud

@prestonBot

This comment has been minimized.

Copy link
Collaborator

prestonBot commented Aug 22, 2018

This comment has been migrated from the Forge. Read the original comment here.

  • Author: jonathan.lelievre
  • Created at: Fri, 17 Aug 2018 14:36:44 +0200

PrestaShop/ps_viewedproduct#7

@jolelievre jolelievre moved this from To be reviewed to To be tested in PrestaShop 1.7.5 Sep 6, 2018

@marionf marionf moved this from To be tested to In progress in PrestaShop 1.7.5 Sep 6, 2018

@marionf marionf moved this from In progress to To be reviewed in PrestaShop 1.7.5 Sep 7, 2018

@jolelievre jolelievre moved this from To be reviewed to To be tested in PrestaShop 1.7.5 Sep 11, 2018

@jolelievre jolelievre moved this from To be tested to To be merged in PrestaShop 1.7.5 Sep 11, 2018

@jolelievre jolelievre moved this from To be merged to Done in PrestaShop 1.7.5 Sep 11, 2018

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Sep 19, 2018

The PR has been merged however it requires a release of the module to be shipped with PrestaShop 1.7.5 ⚠️

@matks

This comment has been minimized.

Copy link
Contributor

matks commented Sep 21, 2018

Module has been released

@matks matks closed this Sep 21, 2018

@marionf marionf added the Fixed label Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment