New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong bash conditions in check_file_syntax file #10089

Merged
merged 1 commit into from Aug 23, 2018

Conversation

Projects
None yet
2 participants
@PierreRambaud
Contributor

PierreRambaud commented Aug 23, 2018

Questions Answers
Branch? develop
Description? use a proper way to test in bash script
Type? bug fix
Category? TE
BC breaks? no
Deprecations? no
How to test? Wait for CI.

This change is Reviewable

@PierreRambaud PierreRambaud requested a review from mickaelandrieu Aug 23, 2018

@PierreRambaud PierreRambaud changed the title from Wrong bash conditions in tcheck_file_syntax files to Wrong bash conditions in check_file_syntax file Aug 23, 2018

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 23, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 23, 2018

Member

No need of QA review on this one. To be merged when tests pass.

Member

Quetzacoalt91 commented Aug 23, 2018

No need of QA review on this one. To be merged when tests pass.

@Quetzacoalt91 Quetzacoalt91 merged commit 6b5a03d into PrestaShop:develop Aug 23, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91
Member

Quetzacoalt91 commented Aug 23, 2018

Thank you @PierreRambaud

@PierreRambaud PierreRambaud deleted the PierreRambaud:fix-travis-config branch Aug 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment