New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOOM-6197] PDF documents unformatted #10135

Merged
merged 2 commits into from Sep 8, 2018

Conversation

Projects
None yet
6 participants
@rdy4ever
Contributor

rdy4ever commented Aug 24, 2018

Fix for #9527

Questions Answers
Branch? develop
Description? Fix for #9527
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9527
How to test? In the Admin back office, try to print an order.

This change is Reviewable

@rdy4ever rdy4ever changed the title from [BOOM-6197] PDF documents unformatted #9527 to [BOOM-6197] PDF documents unformatted Aug 24, 2018

@ntiepresta

This comment has been minimized.

Show comment
Hide comment
@ntiepresta

ntiepresta Aug 28, 2018

Hi, @rdy4ever
we manage to reproduce the issue with PS 1.7.4.0 . But this modification doesn’t resolved the issue. We have the same behavior after correcting
Best regards, Reddy Ntie

ntiepresta commented Aug 28, 2018

Hi, @rdy4ever
we manage to reproduce the issue with PS 1.7.4.0 . But this modification doesn’t resolved the issue. We have the same behavior after correcting
Best regards, Reddy Ntie

rdy4ever and others added some commits Aug 24, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Sep 7, 2018

Member

I confirm it does work.

capture du 2018-09-07 14-55-36

@rdy4ever, I updated your PR by rebasing an regenerating the assets, I hope you don't mind.
@ntiepresta can you please try again?

Member

Quetzacoalt91 commented Sep 7, 2018

I confirm it does work.

capture du 2018-09-07 14-55-36

@rdy4ever, I updated your PR by rebasing an regenerating the assets, I hope you don't mind.
@ntiepresta can you please try again?

@ntiepresta

This comment has been minimized.

Show comment
Hide comment
@ntiepresta

ntiepresta commented Sep 7, 2018

@Quetzacoalt91 ,
Ok, No problem.

@ntiepresta ntiepresta removed their assignment Sep 7, 2018

@ntiepresta ntiepresta added QA ✔️ and removed waiting for QA labels Sep 7, 2018

@rdy4ever

This comment has been minimized.

Show comment
Hide comment
@rdy4ever

rdy4ever Sep 7, 2018

Contributor

@Quetzacoalt91 no problem, thanks!

Contributor

rdy4ever commented Sep 7, 2018

@Quetzacoalt91 no problem, thanks!

@PierreRambaud PierreRambaud merged commit 35edb8a into PrestaShop:develop Sep 8, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@PierreRambaud

This comment has been minimized.

Show comment
Hide comment
@PierreRambaud

PierreRambaud Sep 8, 2018

Contributor

Thanks @rdy4ever

Contributor

PierreRambaud commented Sep 8, 2018

Thanks @rdy4ever

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment