New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy AdminBackup controller #10139

Merged
merged 1 commit into from Aug 27, 2018

Conversation

Projects
None yet
5 participants
@sarjon
Member

sarjon commented Aug 25, 2018

Questions Answers
Branch? develop
Description? Backup page was migrated, but controller was not removed (my bad, thanks @mickaelandrieu for noticing). This PR removes it.
Type? bug fix
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? n/a
How to test? Nothing to test.

This change is Reviewable

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 25, 2018

Contributor

👍

Contributor

mickaelandrieu commented Aug 25, 2018

👍

@PierreRambaud PierreRambaud added this to the 1.7.5.0 milestone Aug 27, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 27, 2018

Contributor

Ping @eternoendless, no need QA approval, it's only removal of not used controller (migrated to Symfony)

Contributor

mickaelandrieu commented Aug 27, 2018

Ping @eternoendless, no need QA approval, it's only removal of not used controller (migrated to Symfony)

@mickaelandrieu mickaelandrieu merged commit 21d1aec into PrestaShop:develop Aug 27, 2018

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 27, 2018

Contributor

Thanks @sarjon !

Contributor

mickaelandrieu commented Aug 27, 2018

Thanks @sarjon !

@matks matks added the migration label Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment