New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trusted modules cache creation #10155

Merged
merged 6 commits into from Aug 28, 2018

Conversation

Projects
None yet
4 participants
@jocel1
Contributor

jocel1 commented Aug 27, 2018

Questions Answers
Branch? develop
Description? CACHE_FILE_DEFAULT_COUNTRY_MODULES_LIST was not properly used to generate the trusted / untrusted cache list, slowing down a lot each call to getModulesOnDisk()
Type? bug fix
Category? CO
BC breaks? no
Deprecations? no
How to test? run tests

This change is Reviewable

jocel1 added some commits Aug 27, 2018

@jocel1 jocel1 added this to the 1.7.5.0 milestone Aug 27, 2018

@jocel1 jocel1 requested a review from mickaelandrieu Aug 27, 2018

Module::deleteTrustedXmlCache();
Module::getModulesOnDisk();
$trustedFileCreationTime = filemtime(_PS_ROOT_DIR_.'/config/xml/trusted_modules_list.xml');
sleep(1);

This comment has been minimized.

@mickaelandrieu

mickaelandrieu Aug 27, 2018

Contributor

are you sure you need a sleep() here?

@mickaelandrieu

mickaelandrieu Aug 27, 2018

Contributor

are you sure you need a sleep() here?

This comment has been minimized.

@jocel1

jocel1 Aug 27, 2018

Contributor

unfortunately yes, I checked my test was failing without the fix, and it without the sleep(1) it was failing randomly

@jocel1

jocel1 Aug 27, 2018

Contributor

unfortunately yes, I checked my test was failing without the fix, and it without the sleep(1) it was failing randomly

@mickaelandrieu

ping @Quetzacoalt91 for presta trust stuff :)

jocel1 added some commits Aug 27, 2018

@Quetzacoalt91

This comment has been minimized.

Show comment
Hide comment
@Quetzacoalt91

Quetzacoalt91 Aug 28, 2018

Member

@mickaelandrieu this PR is not related to PrestaTrust. :)

It is related to another system, which checks that a module is part of the marketplace database.

Member

Quetzacoalt91 commented Aug 28, 2018

@mickaelandrieu this PR is not related to PrestaTrust. :)

It is related to another system, which checks that a module is part of the marketplace database.

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 28, 2018

Contributor

@Quetzacoalt91 aww, I'm not aware at all of this part of PrestaShop ^^

Thanks for review and good job @jocel1

Contributor

mickaelandrieu commented Aug 28, 2018

@Quetzacoalt91 aww, I'm not aware at all of this part of PrestaShop ^^

Thanks for review and good job @jocel1

@mickaelandrieu mickaelandrieu merged commit dde2223 into PrestaShop:develop Aug 28, 2018

1 of 2 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment