New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small ux optimizations #10170

Merged
merged 6 commits into from Aug 29, 2018

Conversation

Projects
None yet
6 participants
@CaptainYouz
Contributor

CaptainYouz commented Aug 28, 2018

Questions Answers
Branch? develop
Description? Implementation of small UI changes in BO> Product Page> New Product. Issue #9488
Type? improvement
Category? BO
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #9488
How to test? See UI changes before/after in BO Product Page

This change is Reviewable

@prestonBot

This comment has been minimized.

Show comment
Hide comment
@prestonBot

prestonBot Aug 28, 2018

Collaborator

Hello @CaptainYouz!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

Collaborator

prestonBot commented Aug 28, 2018

Hello @CaptainYouz!

This is your first pull request on the PrestaShop project. Thank you, and welcome to this Open Source community!

@LouiseBonnard

This comment has been minimized.

Show comment
Hide comment
@LouiseBonnard

LouiseBonnard Aug 29, 2018

Contributor

Can somebody tell me if there are a lot of strings to check in the PR? Diff files are quite heavy to load (even with the Reviewable tool) and make the search for wording pretty difficult. :-(

Contributor

LouiseBonnard commented Aug 29, 2018

Can somebody tell me if there are a lot of strings to check in the PR? Diff files are quite heavy to load (even with the Reviewable tool) and make the search for wording pretty difficult. :-(

@CaptainYouz

This comment has been minimized.

Show comment
Hide comment
@CaptainYouz

CaptainYouz Aug 29, 2018

Contributor

@LouiseBonnard no strings were changed/modified for this issue.

Contributor

CaptainYouz commented Aug 29, 2018

@LouiseBonnard no strings were changed/modified for this issue.

@LouiseBonnard

This comment has been minimized.

Show comment
Hide comment
@LouiseBonnard

LouiseBonnard Aug 29, 2018

Contributor

@CaptainYouz, great, thanks Anas!

Contributor

LouiseBonnard commented Aug 29, 2018

@CaptainYouz, great, thanks Anas!

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 29, 2018

Contributor

Hello @CaptainYouz, would you mind to rebase your contribution and build (again) the assets?

Then I can put the 'Waiting for QA' label

Contributor

mickaelandrieu commented Aug 29, 2018

Hello @CaptainYouz, would you mind to rebase your contribution and build (again) the assets?

Then I can put the 'Waiting for QA' label

@CaptainYouz

This comment has been minimized.

Show comment
Hide comment
@CaptainYouz
Contributor

CaptainYouz commented Aug 29, 2018

@mickaelandrieu done :)

@PierreRambaud PierreRambaud changed the title from Small ux optimizations | Issue #9488 to Small ux optimizations Aug 29, 2018

@ntiepresta ntiepresta self-assigned this Aug 29, 2018

@marionf marionf assigned marionf and unassigned ntiepresta Aug 29, 2018

@marionf marionf added the QA ✔️ label Aug 29, 2018

@marionf marionf removed the waiting for QA label Aug 29, 2018

@marionf marionf removed their assignment Aug 29, 2018

@mickaelandrieu

This comment has been minimized.

Show comment
Hide comment
@mickaelandrieu

mickaelandrieu Aug 29, 2018

Contributor

Thanks @CaptainYouz & everyone for review

Contributor

mickaelandrieu commented Aug 29, 2018

Thanks @CaptainYouz & everyone for review

@mickaelandrieu mickaelandrieu merged commit 7e10dcf into PrestaShop:develop Aug 29, 2018

1 of 2 checks passed

code-review/reviewable 26 files left
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mickaelandrieu mickaelandrieu added this to the 1.7.5.0 milestone Aug 29, 2018

@CaptainYouz CaptainYouz deleted the CaptainYouz:small-ux-optimizations branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment